Skip to content

[Merged by Bors] - ci: remove special support for ProofWidgets4 cloud releases#37290

Closed
Vtec234 wants to merge 7 commits intomasterfrom
ci-dev/rm-pw4-cache
Closed

[Merged by Bors] - ci: remove special support for ProofWidgets4 cloud releases#37290
Vtec234 wants to merge 7 commits intomasterfrom
ci-dev/rm-pw4-cache

Conversation

@Vtec234
Copy link
Copy Markdown
Contributor

@Vtec234 Vtec234 commented Mar 27, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

PR summary 8807830d8b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- getProofWidgets
- has_proofwidgets_dependency(checkout_dir:
- verify_proofwidgets_toolchain(checkout_dir:

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

⚠️ Workflow documentation reminder

This PR modifies files under .github/workflows/.
Please update docs/workflows.md if the workflow inventory, triggers, or behavior changed.

Modified workflow files:

  • .github/workflows/build_template.yml

Comment thread .github/workflows/build_template.yml Outdated

echo "✅ ProofWidgets source URL is allowed: $proofwidgets_url"

- name: verify ProofWidgets lean-toolchain matches on versioned releases
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in #31723. We no longer need to pin ProofWidgets4 to a specific tagged version after this PR. Indeed, all the other dependencies are required as main. But actually using a tagged version seems like good practice. So I see two options:

  • Keep require proofwidgets at a tagged version, and keep this CI check.
  • Use main, remove the CI check.

Btw, it seems to duplicate functionality of verify_proofwidgets_toolchain in scripts/verify_version_tags.py. But there are no references to that script (only meant to be run locally? introduced in #32162).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to remove this independently of using a tagged version or not.

Copy link
Copy Markdown
Contributor Author

@Vtec234 Vtec234 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the 'verify ProofWidgets lean-toolchain matches on versioned releases' step is supposed to make sure that the person bumping the Lean version remembers to update the tagged ProofWidgets as well. Do we not want that check anymore?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the details here... why are these things coupled?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I think it was because using the wrong version would fail to fetch the cloud release, consequently triggering rebuilds. It should no longer do so, so I normalized proofwidgets to be required from main like all the other dependencies.

@Vtec234 Vtec234 requested a review from marcelolynch March 28, 2026 15:19
Copy link
Copy Markdown
Contributor

@marcelolynch marcelolynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, but looks good, thanks for this!

Comment thread lakefile.lean Outdated
Comment thread .github/workflows/build_template.yml Outdated

echo "✅ ProofWidgets source URL is allowed: $proofwidgets_url"

- name: verify ProofWidgets lean-toolchain matches on versioned releases
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to remove this independently of using a tagged version or not.

Comment thread Cache/Main.lean
@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 30, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 30, 2026
@Vtec234
Copy link
Copy Markdown
Contributor Author

Vtec234 commented Mar 30, 2026

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 30, 2026

🔒 Permission denied

Existing reviewers: click here to make Vtec234 a reviewer

@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 30, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 30, 2026
This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 31, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci: remove special support for ProofWidgets4 cloud releases [Merged by Bors] - ci: remove special support for ProofWidgets4 cloud releases Mar 31, 2026
@mathlib-bors mathlib-bors bot closed this Mar 31, 2026
Rob23oba pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Mar 31, 2026
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants