[Merged by Bors] - ci: remove special support for ProofWidgets4 cloud releases#37290
[Merged by Bors] - ci: remove special support for ProofWidgets4 cloud releases#37290
Conversation
Validation is no longer needed when we are not fetching cloud releases.
PR summary 8807830d8bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
|
||
| echo "✅ ProofWidgets source URL is allowed: $proofwidgets_url" | ||
|
|
||
| - name: verify ProofWidgets lean-toolchain matches on versioned releases |
There was a problem hiding this comment.
This was introduced in #31723. We no longer need to pin ProofWidgets4 to a specific tagged version after this PR. Indeed, all the other dependencies are required as main. But actually using a tagged version seems like good practice. So I see two options:
- Keep
require proofwidgetsat a tagged version, and keep this CI check. - Use
main, remove the CI check.
Btw, it seems to duplicate functionality of verify_proofwidgets_toolchain in scripts/verify_version_tags.py. But there are no references to that script (only meant to be run locally? introduced in #32162).
There was a problem hiding this comment.
I think it's good to remove this independently of using a tagged version or not.
There was a problem hiding this comment.
IIRC the 'verify ProofWidgets lean-toolchain matches on versioned releases' step is supposed to make sure that the person bumping the Lean version remembers to update the tagged ProofWidgets as well. Do we not want that check anymore?
There was a problem hiding this comment.
I don't know the details here... why are these things coupled?
There was a problem hiding this comment.
Ok, so I think it was because using the wrong version would fail to fetch the cloud release, consequently triggering rebuilds. It should no longer do so, so I normalized proofwidgets to be required from main like all the other dependencies.
marcelolynch
left a comment
There was a problem hiding this comment.
A minor comment, but looks good, thanks for this!
|
|
||
| echo "✅ ProofWidgets source URL is allowed: $proofwidgets_url" | ||
|
|
||
| - name: verify ProofWidgets lean-toolchain matches on versioned releases |
There was a problem hiding this comment.
I think it's good to remove this independently of using a tagged version or not.
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make Vtec234 a reviewer |
|
Thanks! |
This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
|
Pull request successfully merged into master. Build succeeded: |
…er-community#37290) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
…er-community#37290) This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
This PR removes special support for ProofWidgets4 cloud releases. See leanprover-community/ProofWidgets4#165.
CI runs:
https://github.com/leanprover-community/mathlib4/actions/runs/23669823972
https://github.com/leanprover-community/mathlib4/actions/runs/23768342866