refactor(AtLocation): allow throwing a warning when no progress is being made#37899
Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Closed
refactor(AtLocation): allow throwing a warning when no progress is being made#37899grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 25560be005Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
grunweg
changed the title
grunweg
force-pushed
the
configure-warnings2
branch
from
ebcc419 to
5bff01b
Compare
grunweg
changed the title
grunweg
added
awaiting-CI
This was referenced Apr 10, 2026
Open
github-actions
bot
removed
the
awaiting-CI
grunweg
added
the
awaiting-CI
grunweg
force-pushed
the
configure-warnings2
branch
from
fe38b19 to
cbb8093
Compare
grunweg
added a commit
to grunweg/mathlib4
that referenced
this pull request
Apr 13, 2026
Make errors in AtLocation surround the tactic name with backticks by default. This fixes a few error messages to comply with mathlib's style guide. Extracted from leanprover-community#37899.
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
grunweg
removed
the
awaiting-CI
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
Make errors in AtLocation surround the tactic name with backticks by default. This fixes a few error messages to comply with mathlib's style guide. Extracted from #37899.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
Make errors in AtLocation surround the tactic name with backticks by default. This fixes a few error messages to comply with mathlib's style guide. Extracted from #37899. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
…ing made A future PR will use this to make `by_contra!` and friends warn if the `push_neg` step makes no progress. The `push_neg` and `ring_nf` tactic configuration options are already modified to allow this; no behaviour changes are performed as part of this PR. Co-authored by: Jovan Gerbscheid <jovan.gerbscheid@gmail.com>
grunweg
force-pushed
the
configure-warnings2
branch
from
71a30c4 to
476f69f
Compare
Contributor
Author
|
I'm happy with this PR: let's land it at #31597. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A future PR will use this to make
by_contra!and friends warn if thepush_negstep makes no progress.The
push_negandring_nftactic configuration options are already modified accordingly;no behaviour changes are performed as part of this PR.
Co-authored by: Jovan Gerbscheid jovan.gerbscheid@gmail.com
New incantation of #31597. I'm happy to overwrite that branch instead, if preferred.