[Merged by Bors] - feat(push): error message tweaks#38008
Closed
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(push): error message tweaks#38008grunweg wants to merge 3 commits intoleanprover-community:masterfrom
grunweg wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 10b21fc2a1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
5 tasks
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
2 tasks
logWarning does most of the heavy listing (by adding the necessary message context), so this was very easy. Also add a test for the current push_neg error if no progress was made. Making it print the constant pushed would be more readable (but that is not as obvious).
grunweg
force-pushed
the
atlocation-message-tweaks
branch
from
da3e30a to
a57352e
Compare
grunweg
removed
the
blocked-by-other-PR
Contributor
Author
|
@JovanGerb I'm also curious what you think about the error message change. |
JovanGerb
reviewed
Apr 14, 2026
Contributor
JovanGerb
left a comment
JovanGerb
left a comment
There was a problem hiding this comment.
Yes, this seems like a good idea to me.
Contributor
|
The PR description seems off. You say "declaration names". Did you mean "free variables"? |
|
This PR/issue depends on:
|
Contributor
Author
|
Thanks, both fixed now! |
Open
3 tasks
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by JovanGerb. |
mathlib-triage
bot
added
the
maintainer-merge
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
- make free variables in all errors "made no progress" hoverable (this applies also to ring, abel, field_simp, ...) - include the constant being pushed in the error message
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.