Adding on page bookmark support to links#784
Closed
dustinryerson wants to merge 2 commits intoliferay:masterfrom
dustinryerson:pr-3
Closed
Adding on page bookmark support to links#784dustinryerson wants to merge 2 commits intoliferay:masterfrom dustinryerson:pr-3
dustinryerson wants to merge 2 commits intoliferay:masterfrom
dustinryerson:pr-3
Conversation
Member
|
ci:retest |
Member
|
It was worth a try, @dustinryerson , do you know perhaps how to rerun the Travis job? |
jbalsas
suggested changes
Oct 30, 2017
Contributor
jbalsas
left a comment
There was a problem hiding this comment.
Hey @balazssk, @dustinryerson, I've relaunched the tests.
On a first look, we need several things to change so we can accept this:
- Can you create an issue in this repo explaining the new feature you want to add?
- You need to add a line at the end of each commit that aims to fix this by saying
Fixes #issueso we can track it down properly - You need to add tests that cover the new condition 😉
Thanks!
Member
|
Hi @jbalsas thank you for your feedback! Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.