Skip to content

Adding on page bookmark support to links#784

Closed
dustinryerson wants to merge 2 commits intoliferay:masterfrom
dustinryerson:pr-3
Closed

Adding on page bookmark support to links#784
dustinryerson wants to merge 2 commits intoliferay:masterfrom
dustinryerson:pr-3

Conversation

@dustinryerson
Copy link
Copy Markdown
Contributor

No description provided.

@balazssk
Copy link
Copy Markdown
Member

ci:retest

@balazssk
Copy link
Copy Markdown
Member

It was worth a try, @dustinryerson , do you know perhaps how to rerun the Travis job?

Copy link
Copy Markdown
Contributor

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @balazssk, @dustinryerson, I've relaunched the tests.

On a first look, we need several things to change so we can accept this:

  • Can you create an issue in this repo explaining the new feature you want to add?
  • You need to add a line at the end of each commit that aims to fix this by saying Fixes #issue so we can track it down properly
  • You need to add tests that cover the new condition 😉

Thanks!

@balazssk
Copy link
Copy Markdown
Member

Hi @jbalsas thank you for your feedback!
As this PR belongs do @dustinryerson , I'll open a new PR with the updates and you can close this one.

Thanks,
Balazs

@jbalsas jbalsas closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants