Skip to content

Adding on page bookmark support to links #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dustinryerson wants to merge 2 commits into from
Closed

Adding on page bookmark support to links #784

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148a66f
adding on page bookmark support to links
balazssk Oct 24, 2017
bfb5d24
Update function description
dustinryerson Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/core/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
(function() {
'use strict';

var REGEX_BOOKMARK_SCHEME = /^#.*/i;
var REGEX_EMAIL_SCHEME = /^[a-z0-9\u0430-\u044F\._-]+@/i;
var REGEX_URI_SCHEME = /^(?:[a-z][a-z0-9+\-.]*)\:|^\//i;

Expand Down Expand Up @@ -214,8 +215,9 @@
},

/**
* Checks if the URI has an '@' symbol. If it does and the URI looks like an email
* and doesn't have 'mailto:', 'mailto:' is added to the URI.
* Checks if the URI begins with a '#' symbol to determine if it's an on page bookmark.
* If it doesn't, it then checks if the URI has an '@' symbol. If it does and the URI
* looks like an email and doesn't have 'mailto:', 'mailto:' is added to the URI.
* If it doesn't and the URI doesn't have a scheme, the default 'http' scheme with
* hierarchical path '//' is added to the URI.
*
Expand All @@ -227,7 +229,9 @@
* @return {String} The URI updated with the protocol.
*/
_getCompleteURI: function(URI) {
if (REGEX_EMAIL_SCHEME.test(URI)) {
if (REGEX_BOOKMARK_SCHEME.test(URI)) {
return URI;
} else if (REGEX_EMAIL_SCHEME.test(URI)) {
URI = 'mailto:' + URI;
} else if (!REGEX_URI_SCHEME.test(URI)) {
URI = this.appendProtocol ? 'http://' + URI : URI;
Expand Down
⚡