[c++] fail when forcedsplits_filename points to missing file#7197
Open
[c++] fail when forcedsplits_filename points to missing file#7197
Conversation
jameslamb
requested changes
Mar 13, 2026
Member
jameslamb
left a comment
There was a problem hiding this comment.
There is already a human-submitted PR for this issue, and it has significant discussion.
Instead of this, could you please help that move forward?
I'd also like to know... in whatever you're doing to generate these PRs, would the bot ignore issues that are already assigned? If so I think we should make a habit of assigning issues to contributors once they open PRs, to avoid PRs like this one and #7184 and #7197 being opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forcedsplits_filenameis set but the file cannot be openedLightGBMErrorTesting
./lightgbm config=examples/binary_classification/train.conf data=examples/binary_classification/binary.train valid_data=examples/binary_classification/binary.test num_iterations=1 forced_splits=examples/binary_classification/does_not_exist.json./lightgbm config=examples/binary_classification/train.conf data=examples/binary_classification/binary.train valid_data=examples/binary_classification/binary.test num_iterations=1 forced_splits=examples/binary_classification/forced_splits.jsonconda run -n lightgbm python -m pytest tests/python_package_test/test_engine.py -k "forced_split_feature_indices or forced_split_missing_file" -qFixes #6830