Skip to content

[c++] fail when forcedsplits_filename points to missing file #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiyu1994 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

[c++] fail when forcedsplits_filename points to missing file #7197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/boosting/gbdt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ void GBDT::Init(const Config* config, const Dataset* train_data, const Objective
// load forced_splits file
if (!config->forcedsplits_filename.empty()) {
std::ifstream forced_splits_file(config->forcedsplits_filename.c_str());
if (forced_splits_file.fail()) {
Log::Fatal("Could not open %s", config->forcedsplits_filename.c_str());
}
std::stringstream buffer;
buffer << forced_splits_file.rdbuf();
std::string err;
Expand Down Expand Up @@ -840,6 +843,9 @@ void GBDT::ResetConfig(const Config* config) {
if (!new_config->forcedsplits_filename.empty()) {
std::ifstream forced_splits_file(
new_config->forcedsplits_filename.c_str());
if (forced_splits_file.fail()) {
Log::Fatal("Could not open %s", new_config->forcedsplits_filename.c_str());
}
std::stringstream buffer;
buffer << forced_splits_file.rdbuf();
std::string err;
Expand Down
8 changes: 8 additions & 0 deletions tests/python_package_test/test_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3429,6 +3429,14 @@ def test_forced_split_feature_indices(tmp_path):
lgb.train(params, lgb_train)


def test_forced_split_missing_file(tmp_path):
X, y = make_synthetic_regression()
lgb_train = lgb.Dataset(X, y)
params = {"objective": "regression", "forcedsplits_filename": tmp_path / "does_not_exist.json"}
with pytest.raises(lgb.basic.LightGBMError, match="Could not open"):
lgb.train(params, lgb_train)


def test_forced_bins():
x = np.empty((100, 2))
x[:, 0] = np.arange(0, 1, 0.01)
Expand Down
Loading
⚡