Fix argument parsing: Properly handle -- to separate files and script arguments#90
Merged
aatxe merged 2 commits intoluau-lang:primaryfrom Feb 26, 2025
Merged
Conversation
added 2 commits
February 26, 2025 15:48
Compatibility with CMake < 3.5 has been removed from CMake.
aatxe
approved these changes
Feb 26, 2025
Member
|
Thanks! |
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
…pt arguments (luau-lang#90) Previously, lute treated arguments after -- as files instead of script arguments. This caused errors like: ```sh Error opening ./1 Error opening ./2 Error opening ./3 ``` since ```1 2 3``` were misinterpreted as file paths. This PR does the following: - Ensures -- properly marks the transition between files and arguments. - Converts argv[i] from char* to std::string before pushing it into files. (Misc) Closes luau-lang#86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, lute treated arguments after -- as files instead of script arguments. This caused errors like:
since
1 2 3were misinterpreted as file paths.This PR does the following:
Closes #86