Add TLS 1.3 and curve X25519#53
Open
J0WI wants to merge 1 commit intomatomo-org:masterfrom
Open
Conversation
Findus23
requested changes
Feb 13, 2020
Collaborator
Findus23
left a comment
Findus23
left a comment
There was a problem hiding this comment.
Thanks for the contribution and sorry I missed it.
| ssl_protocols TLSv1.2; | ||
| ssl_protocols TLSv1.3 TLSv1.2; | ||
| ssl_ciphers 'ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256'; | ||
| ssl_ecdh_curve X25519:secp521r1:secp384r1; |
Collaborator
There was a problem hiding this comment.
Any argument why one should limit oneself to these specific curves?
https://ssl-config.mozilla.org/ doesn't mention them
I try to keep the config non-opinionated as tls-cuves have little to do with Matomo itself but are more the decision of the server admin.
Author
There was a problem hiding this comment.
|
|
||
| # modern configuration. tweak to your needs. | ||
| ssl_protocols TLSv1.2; | ||
| ssl_protocols TLSv1.3 TLSv1.2; |
Collaborator
There was a problem hiding this comment.
Do you know what happens if nginx doesn't support TLS1.3? (Which isn't that rare yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.