Skip to content

Add TLS 1.3 and curve X25519 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
J0WI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add TLS 1.3 and curve X25519 #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ssl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ ssl_session_cache shared:SSL:50m;
ssl_session_tickets off;

# modern configuration. tweak to your needs.
ssl_protocols TLSv1.2;
ssl_protocols TLSv1.3 TLSv1.2;
Copy link
Copy Markdown
Collaborator

@Findus23 Findus23 Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what happens if nginx doesn't support TLS1.3? (Which isn't that rare yet)

ssl_ciphers 'ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256';
ssl_ecdh_curve X25519:secp521r1:secp384r1;
Copy link
Copy Markdown
Collaborator

@Findus23 Findus23 Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any argument why one should limit oneself to these specific curves?
https://ssl-config.mozilla.org/ doesn't mention them

I try to keep the config non-opinionated as tls-cuves have little to do with Matomo itself but are more the decision of the server admin.

Copy link
Copy Markdown
Author

@J0WI J0WI Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wiki.mozilla.org/Security/Server_Side_TLS#Modern_compatibility

ssl_prefer_server_ciphers on;

# OCSP Stapling ---
Expand Down
⚡