-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add a Segment Management Page #23885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
9f0561b
Initiate the Segment Management Page
tzi 71caaf2
Update UI screenshots and fix tests
tzi 9cf112c
Only display data for pre-processed segments
tzi e2e3589
Fix the tooltip synchronisation after segment star state change
tzi cabac88
Revert UI Screenshot change
tzi 6186545
Create Dashboard link with an accessible idSite
tzi 38e9a6b
Build dashboard link on the client side
tzi 97550c5
Handle string enable_only_idsite
tzi b9e3185
Add tests on title, order, and synchronisation
tzi d2541b7
Add test on edit button
tzi 0826eb9
Update UI screenshot
tzi 94b768a
Redesign real-time segment notice after team feedback
tzi 063e49d
Consolidate and add more tests
tzi 7f3acca
Create back-end Fixture for #23885 (#24161)
tzi 7a41168
More Stable SegmentSelectorEditor test
tzi fe7fa0b
Feedback from @chippison
tzi 561dffb
Make listeners return unsubscribe handlers to prevent duplicate handlers
tzi 696a23c
Vue build
tzi 665f4d3
Fix - Allow to remove 'All Visits' from comparisons
tzi b097d8c
restore browser-trigger archiving state in SegmentEditor ControllerTe…
tzi 0bdb92d
Do not update TagManager
tzi b538573
Load data for the ManageSegmentPage line by line from front-end async…
tzi 6eb1232
Securize segment data/delete flows and stabilize async ManageSegmentP…
tzi 69006e1
Sanitize segment-data errors and test sequential loading after row fa…
tzi dadf54a
Fix tests
tzi 8dd7a91
stabilize UI tests
tzi 187d960
add new segment management page to whats new list (#24189)
nathangavin c709625
stabilize UI tests
tzi 29b7126
Small back-end optimisation
tzi 4127eea
Fix front-end user right to star/edit/delete segment
tzi c09bc02
Fix segment search in segment panel
tzi 97ee83a
Move SegmentEditor.getSegmentData to API file and rename parameter (#…
tzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...nsions/tests/UI/expected-screenshots/CustomDimensions_report_visit_mainmenu.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.