Conversation
13932db to
597f770
Compare
adcf8af to
6fb66bd
Compare
fc0cb9b to
e353f4f
Compare
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
tzi
commented
Jan 12, 2026
chippison
previously approved these changes
Mar 9, 2026
Contributor
|
Did some basic testing The re-ordering on starring is jarring, so much I thought it was a bug, but that's not up for discussion now. Here is a test report of what I covered.
|
10 tasks
…24199) * SegmentEditor.getSegmentData API moved to the API file and renamed parameter * Fix evolution icons
caddoo
approved these changes
Mar 11, 2026
nathangavin
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #20659
We propose the introduction of a new page in Matomo, titled "Segments."
This page will serve as a combined reporting and management tool to make it easy to view (and edit) all segments for a website, and also provide a clean dashboard to view All segment data at once.
Features
If needed, a tooltip explain why we cannot do an action. If it is a global segment, the tooltip precise that starring/unstarring it will affect all websites.
If we choose to edit a segment, it opens the segmentEditorPanel
If we choose to delete a segment, it opens the segmentEditorPanel and trigger a new modal that ask confirmation before deleting it.
Data Synchronization with the Panel
Starring/Unstarring will reorder segments without reload. The Page and the Panel are always synchronized.
Menus
We added an
outlinkicon to the administration because this link goes back to the Dashboard. We choose this behaviour because the website / date / segment selector are needed and not available in the administration layout.Plugins
This PR will have impact on plugins UI screenshots:
Checklist
Review