Conversation
tzi
added
the
not-in-changelog
tzi
force-pushed
the
ux-326-3
branch
3 times, most recently
from
b683825 to
22c8602
Compare
caddoo
approved these changes
Mar 10, 2026
Contributor
|
@tzi I've approved and merged, although the test files are a bit odd, the API is being tested in Can you do a follow up PR to tidy this, so that the API tests are isolated, system tests should be enough. |
caddoo
pushed a commit
that referenced
this pull request
Mar 11, 2026
* Initiate the Segment Management Page Add 'All Visits at the top' Reorder segments: fixed > selected > starred > others Add highlighted styles to fixed and selected segments Allow star/unstar segments Reorder data Add view, edit, and delete actions Synchronize UI between the editor panel and the management page Align number to the right Add right management Use translation for the page description Implement the search segment Add tooltip on view action Add a create segment button Add sparkline UX Meeting feedback Add a menu entry into the Administration menu + colored evolution Fix range selection Update evolution tooltip Add manage segment button Remove tooltip on sparkline when using a custom range Reorder administration menu and add an outlink icon Use generic table tooltip instead of custom ones Fix PHPCS Fix PHP errors Update the Scheduled Reports help box about segment Move JavaScript in a separate file and fix a bug when we unstar selected segment Bugfix: not all users are allowed to create segments Change translation key since the parameters changed No need to have write access to be able to see the segment management page Fix UI feedback on failing star/unstar api calls First round of Stefan’s feedback * Update UI screenshots and fix tests Update UI screenshots Update UI Screenshots * Only display data for pre-processed segments * Fix the tooltip synchronisation after segment star state change * Revert UI Screenshot change * Create Dashboard link with an accessible idSite * Build dashboard link on the client side * Handle string enable_only_idsite * Add tests on title, order, and synchronisation * Add test on edit button * Update UI screenshot * Redesign real-time segment notice after team feedback * Consolidate and add more tests * Create back-end Fixture for #23885 (#24161) * Create back-end Fixture * Feedback from @sgiehl * Update expected screenshots * More Stable SegmentSelectorEditor test * Feedback from @chippison * Make listeners return unsubscribe handlers to prevent duplicate handlers * Vue build * Fix - Allow to remove 'All Visits' from comparisons * restore browser-trigger archiving state in SegmentEditor ControllerTest teardown * Do not update TagManager * Load data for the ManageSegmentPage line by line from front-end asynchronous calls * Securize segment data/delete flows and stabilize async ManageSegmentPage tests * Sanitize segment-data errors and test sequential loading after row failure * Fix tests * stabilize UI tests * add new segment management page to whats new list (#24189) * stabilize UI tests * Small back-end optimisation * Fix front-end user right to star/edit/delete segment * Fix segment search in segment panel * Move SegmentEditor.getSegmentData to API file and rename parameter (#24199) * SegmentEditor.getSegmentData API moved to the API file and renamed parameter * Fix evolution icons --------- Co-authored-by: Nathan Gavin <nathangavin987@gmail.com>
chippison
pushed a commit
that referenced
this pull request
Mar 16, 2026
* Initiate the Segment Management Page Add 'All Visits at the top' Reorder segments: fixed > selected > starred > others Add highlighted styles to fixed and selected segments Allow star/unstar segments Reorder data Add view, edit, and delete actions Synchronize UI between the editor panel and the management page Align number to the right Add right management Use translation for the page description Implement the search segment Add tooltip on view action Add a create segment button Add sparkline UX Meeting feedback Add a menu entry into the Administration menu + colored evolution Fix range selection Update evolution tooltip Add manage segment button Remove tooltip on sparkline when using a custom range Reorder administration menu and add an outlink icon Use generic table tooltip instead of custom ones Fix PHPCS Fix PHP errors Update the Scheduled Reports help box about segment Move JavaScript in a separate file and fix a bug when we unstar selected segment Bugfix: not all users are allowed to create segments Change translation key since the parameters changed No need to have write access to be able to see the segment management page Fix UI feedback on failing star/unstar api calls First round of Stefan’s feedback * Update UI screenshots and fix tests Update UI screenshots Update UI Screenshots * Only display data for pre-processed segments * Fix the tooltip synchronisation after segment star state change * Revert UI Screenshot change * Create Dashboard link with an accessible idSite * Build dashboard link on the client side * Handle string enable_only_idsite * Add tests on title, order, and synchronisation * Add test on edit button * Update UI screenshot * Redesign real-time segment notice after team feedback * Consolidate and add more tests * Create back-end Fixture for #23885 (#24161) * Create back-end Fixture * Feedback from @sgiehl * Update expected screenshots * More Stable SegmentSelectorEditor test * Feedback from @chippison * Make listeners return unsubscribe handlers to prevent duplicate handlers * Vue build * Fix - Allow to remove 'All Visits' from comparisons * restore browser-trigger archiving state in SegmentEditor ControllerTest teardown * Do not update TagManager * Load data for the ManageSegmentPage line by line from front-end asynchronous calls * Securize segment data/delete flows and stabilize async ManageSegmentPage tests * Sanitize segment-data errors and test sequential loading after row failure * Fix tests * stabilize UI tests * add new segment management page to whats new list (#24189) * stabilize UI tests * Small back-end optimisation * Fix front-end user right to star/edit/delete segment * Fix segment search in segment panel * Move SegmentEditor.getSegmentData to API file and rename parameter (#24199) * SegmentEditor.getSegmentData API moved to the API file and renamed parameter * Fix evolution icons --------- Co-authored-by: Nathan Gavin <nathangavin987@gmail.com> # Conflicts: # tests/UI/expected-screenshots/UIIntegrationTest_period_select_date_range_click.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve #23885 by respecting coding convention:
segmentparameter.Checklist
Review