New MembershipManager for release v0.8.0-rc.1#4744
Closed
Conversation
It was missing a flush.
And remove the IMembershipManager from it
- Add tests for throwing cases - Fixs based on tests
…ing our own state. The scheduled states MembershipActionType.SendFirstDelayedEvent and MembershipActionType.SendJoinEvent both imply that we are already trying to send our own membership state event.
The reset case was not covered properly. There are cases where it is not allowed to add additional events after a reset and cases where we want to add more events after the reset. We need to allow this as a reset property.
also add TODO comment to not forget about this.
4 tasks
Member
Contributor
Author
|
Yes. The PR was unnecessary anyways. We just need the branch in case someone wants to rebuild the rc1 and we force pushed onto the new membership manager branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a branch just to have a non changing target for the v0.8.0-rc.1 release.
the branch toger5/new-MembershipManager will continue to be updated.
This is necassary because of the revert commit: 0cdb075 that messes up the history but without EC would not compile.