Conversation
It was missing a flush.
And remove the IMembershipManager from it
dbkr
left a comment
There was a problem hiding this comment.
Thanks for all the fixes, looking much better. I think you may have had a merge gone wrong though as it looks like there's some reverts crept in here.
This is probably: 0cdb075 which we needed to do to make CI happy. currently EC rc-1 depends on this branch. So we will merge this with the develop branch before we merge the PR. |
0cdb075 to
47a7e4c
Compare
andybalaam
left a comment
There was a problem hiding this comment.
This is way too huge for me to have an opinion on generally, but nothing concerning from a crypto point of view.
This reverts commit 6af4730.
hughns
left a comment
There was a problem hiding this comment.
I like the direction this is heading 👍
Co-authored-by: Hugh Nimmo-Smith <hughns@users.noreply.github.com>
dbkr
left a comment
There was a problem hiding this comment.
Thanks for the changes: I think splitting up the handler function has made a big difference in particular. I think I'm happy to give this a go.
hughns
left a comment
There was a problem hiding this comment.
Awesome. It's great to get this over the line. 👍
|
@toger5 one more thing that could go in this PR, but could be a separate one, is adding some comments to say what is a workaround due to element-hq/synapse#17810 having not landed. This would make it easier to come back and remove the workaround later. |
I will do this as a seperate PR. |
Fixes: https://github.com/element-hq/voip-internal/issues/309
Part of element-hq/element-call#2972.
This does not yet use the new manager by default. It only runs the test suite with it.
Notes on error cases encountered when making HTTP requests to the Homeserver:
MatrixClientstackRoomWidgetClientstackErrorwithname===AbortErrorHttpErrorMatrixErrorConnectionErrorConnectionErroras part of this PRChecklist
public/exportedsymbols have accurate TSDoc documentation.