MatrixRTC: Rename MembershipConfig parameters#4714
Merged
Conversation
Contributor
Author
hughns
changed the title
MembershipConfig parametersMembershipConfig parameters
Contributor
Author
|
Do we want to make this backwards compatible and introduce a couple of deprecated old properties? |
toger5
force-pushed
the
toger5/rename-membership-config
branch
from
db55170 to
c569893
Compare
toger5
changed the base branch from
develop
to
toger5/membership-manager-one-send-delayed-action
Contributor
Author
Contributor
Author
|
Can we make sonar cloud happy event though we use the deprecated fields as fallback? |
We do already have the state `hasMemberEvent` that allows to distinguish the two cases. No need to create two dedicated actions.
- deprecate isJoined (replaced by isActivated) - move Interface types to types.ts
toger5
force-pushed
the
toger5/membership-manager-one-send-delayed-action
branch
from
5acd034 to
052cef9
Compare
toger5
force-pushed
the
toger5/rename-membership-config
branch
from
fc35b3c to
3d60f53
Compare
Base automatically changed from
toger5/membership-manager-one-send-delayed-action
to
develop
March 25, 2025 13:05
robintown
reviewed
Mar 31, 2025
Contributor
Author
|
I am wondering if this should get a breaking change label because of the one property robin mentioned got removed. Technically it does not change anything however since it will continue to be a property with no effect but one can keep it in the config file. Does it make more sense to add the breaking change label to the version that then removes the deprecated fields? |
toger5
added
T-Deprecation
robintown
approved these changes
May 5, 2025
Member
|
T-Deprecation seems appropriate to me |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.