Skip to content

💚 Frontend format & lint job fix#527

Merged
mawoka-myblock merged 6 commits intomawoka-myblock:masterfrom
Proxyfil:fix/frontend-format-lint
Apr 8, 2026
Merged

💚 Frontend format & lint job fix#527
mawoka-myblock merged 6 commits intomawoka-myblock:masterfrom
Proxyfil:fix/frontend-format-lint

Conversation

@Proxyfil
Copy link
Copy Markdown
Contributor

@Proxyfil Proxyfil commented Apr 6, 2026

🎩 What? Why?

This PR aims to fix the frontend lint job.

The versions of pnpm and packages used in the project are not up-to-date.
pnpm version as well as prettier and eslint have got changes in the way that linting and formatting is performed.

The way the change is made can be discussed but because the Dockerfiles use pnpm 10.14.0 I think we can upgrade the version in the CI. The job will still fail because there is a bunch of errors but something working and returning errors is better than not running at all.

(For ESLint look at migration guide)

The rules can be tricked to comply with the needs of the project (drop, warn or error depending of the rule).
I'm open to feedback around this PR, we can probably work on this to do a better work 👍

📌 Related Issues

No issue linked as far as I've search

Testing

To test you can go to frontend folder and run pnpm install && pnpm run format && pnpm run lint

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Not relevant

♥️ Thank you!

@mawoka-myblock
Copy link
Copy Markdown
Owner

Looks good to me in general, I'd be fine merging this as it's way better than it was before/is atm.

@Proxyfil
Copy link
Copy Markdown
Contributor Author

Proxyfil commented Apr 7, 2026

I will check for licence errors in precommit in the next hours and I suggest to merge this if you feel ok with this.

Thank you for your work 💚

@mawoka-myblock
Copy link
Copy Markdown
Owner

To fix these reuse errors, just add a comment header with the MPL statement at the top

@mawoka-myblock
Copy link
Copy Markdown
Owner

Could you please add the license statement as a comment in the corresponding files to remove clutter?

@Proxyfil Proxyfil force-pushed the fix/frontend-format-lint branch from 6995110 to 4b428f7 Compare April 7, 2026 14:39
@Proxyfil
Copy link
Copy Markdown
Contributor Author

Proxyfil commented Apr 7, 2026

Perfect, thanks for the advice ! It's probably cleaner this way

@mawoka-myblock mawoka-myblock merged commit 4a02d48 into mawoka-myblock:master Apr 8, 2026
4 of 5 checks passed
@mawoka-myblock
Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants