💚 Frontend format & lint job fix#527
Merged
mawoka-myblock merged 6 commits intomawoka-myblock:masterfrom Apr 8, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
Owner
|
Looks good to me in general, I'd be fine merging this as it's way better than it was before/is atm. |
Contributor
Author
|
I will check for licence errors in precommit in the next hours and I suggest to merge this if you feel ok with this. Thank you for your work 💚 |
Owner
|
To fix these reuse errors, just add a comment header with the MPL statement at the top |
Owner
|
Could you please add the license statement as a comment in the corresponding files to remove clutter? |
6995110 to
4b428f7
Compare
Contributor
Author
|
Perfect, thanks for the advice ! It's probably cleaner this way |
Owner
|
Thanks! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR aims to fix the frontend lint job.
The versions of pnpm and packages used in the project are not up-to-date.
pnpm version as well as prettier and eslint have got changes in the way that linting and formatting is performed.
The way the change is made can be discussed but because the Dockerfiles use pnpm 10.14.0 I think we can upgrade the version in the CI. The job will still fail because there is a bunch of errors but something working and returning errors is better than not running at all.
(For ESLint look at migration guide)
The rules can be tricked to comply with the needs of the project (drop, warn or error depending of the rule).
I'm open to feedback around this PR, we can probably work on this to do a better work 👍
📌 Related Issues
No issue linked as far as I've search
Testing
To test you can go to
frontendfolder and runpnpm install && pnpm run format && pnpm run lint📋 Checklist
CONSIDER adding a unit test if your PR resolves an issue.DO make sure tests pass.DO add CHANGELOG upgrade notes if required.AVOID breaking the continuous integration build.📷 Screenshots
Not relevant