Skip to content

👷 Added more strict conditions on linting job#532

Merged
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Proxyfil:fix/ci-linting-optimization
Apr 8, 2026
Merged

👷 Added more strict conditions on linting job#532
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Proxyfil:fix/ci-linting-optimization

Conversation

@Proxyfil
Copy link
Copy Markdown
Contributor

@Proxyfil Proxyfil commented Apr 8, 2026

🎩 What? Why?

This PR aims to optimize linting job in CI.

Because of the previous conditions frontend linting CI was running all the time, this isn't a good practice nor very compute-friendly.
Due to the linting upgrade from #527 it should be better to only run this when files that are checked are modified.

We also want to run this when the CI file is modified just to be sure.
These changes should be checked first, than if useful could be added to other CI files too 👍

(This is only for maintainers and contributors experience)

📌 Related Issues

No issue related

Testing

Modify a frontend file, commit, create PR and check if CI runs
Modify a file not impacted by linting, commit, create PR and check if CI doesn't run for linting

📋 Checklist

⚠️ No tests suites for now ⚠️
🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Not relevant

♥️ Your time is precious, thank you for giving it to me !

@mawoka-myblock mawoka-myblock merged commit a90f800 into mawoka-myblock:master Apr 8, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants