👷 Added more strict conditions on linting job#532
Merged
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom Apr 8, 2026
Merged
👷 Added more strict conditions on linting job#532mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
mawoka-myblock merged 1 commit intomawoka-myblock:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR aims to optimize linting job in CI.
Because of the previous conditions frontend linting CI was running all the time, this isn't a good practice nor very compute-friendly.
Due to the linting upgrade from #527 it should be better to only run this when files that are checked are modified.
We also want to run this when the CI file is modified just to be sure.
These changes should be checked first, than if useful could be added to other CI files too 👍
(This is only for maintainers and contributors experience)
📌 Related Issues
No issue related
Testing
Modify a frontend file, commit, create PR and check if CI runs
Modify a file not impacted by linting, commit, create PR and check if CI doesn't run for linting
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
CONSIDER adding a unit test if your PR resolves an issue.DO make sure tests pass.DO add CHANGELOG upgrade notes if required.AVOID breaking the continuous integration build.📷 Screenshots
Not relevant