Add support for lock_ttl to be a Proc/class method#879
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom May 25, 2025
Merged
Add support for lock_ttl to be a Proc/class method#879mhenrixon merged 2 commits intomhenrixon:mainfrom
mhenrixon merged 2 commits intomhenrixon:mainfrom
Conversation
33f0fd6 to
83c0c1d
Compare
Contributor
Author
|
Codeclimbate seems to be failing on TODOs that existed before this PR |
Add the ability to set the lock_ttl to a callable object, such as a Proc or class method. Gives the ability for callers to set the lock_ttl based on the job arguments or other runtime information.
83c0c1d to
51daf3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #878 but to upstream into
mainAdds the ability to set the
lock_ttlto a Proc or class method, allowing callers to set the TTL based on job arguments or other runtime information.For my case, I need to set the
lock_ttldynamically based on one of the arguments supplied. I can accomplish this with a Sidekiq Middleware that runs before SidekiqUniqueJobs, but I'd prefer to provide a proc to calculate.Sample Job