Raise unexpected type error for lock ttl#884
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom Jun 13, 2025
Merged
Conversation
added 2 commits
June 13, 2025 18:53
ActiveSupport::Duration is unexpected.
Contributor
|
@mhenrixon sorry to bother. |
mike3985
added a commit
to alphagov/publishing-api
that referenced
this pull request
Dec 4, 2025
Apparently (mhenrixon/sidekiq-unique-jobs#882, mhenrixon/sidekiq-unique-jobs#884 (comment)) SidekiqUniqueJobs version 8.0.11 seems to have accidentally dropped support for defining lock_ttl as an ActiveSupport::Duration. We do that. And we updated to version 8.0.11 on 27th May this year (#3364). We've been seeing an increase in problems with stale SidekiqUniqueJobs locks these past few months and believed that we'd only just noticed the problem recently because of digging deeper into the issue. I guess there's a chance that this change is the source of those problems? Either way, apprently it needs fixing so now we'll use an integer representing seconds, which SidekiqUniqueJobs definitely supports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #882
ArgumentError is now raised if lock_ttl is an unexpected type.
Also, the README has been modified accordingly.
This change is to prevent returning nil with an unexpected type and tying up the lock.