Merged
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
- Coverage 70.04% 70.04% -0.01%
==========================================
Files 226 226
Lines 27177 27179 +2
Branches 2734 2734
==========================================
+ Hits 19036 19037 +1
- Misses 7197 7198 +1
Partials 944 944 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the replace_functions utility by extracting the core logic into a new replace_functions_inplace function that operates directly on IR models. The original replace_functions now acts as a wrapper that handles proto conversion and calls the new inplace variant.
Key changes:
- Introduces
replace_functions_inplacethat operates onir.Modelandir.Functiontypes directly - Refactors
replace_functionsto convert protos and delegate to the inplace function
titaiwangms
approved these changes
Nov 18, 2025
justinchuby
reviewed
Nov 18, 2025
| def replace_functions( | ||
| model: onnx.ModelProto, functions: Sequence[onnx.FunctionProto] | ||
| ) -> onnx.ModelProto: | ||
| def replace_functions_inplace(irmodel: ir.Model, irfunctions: Sequence[ir.Function]) -> None: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def replace_functions_inplace(irmodel: ir.Model, irfunctions: Sequence[ir.Function]) -> None: | |
| def replace_functions_inplace(model: ir.Model, functions: Collection[ir.Function]) -> None: |
Consider consistent names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo #2703, thanks to Titai.