Skip to content

Provide inplace replacement util #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titaiwangms merged 1 commit into from
Nov 18, 2025
Merged

Provide inplace replacement util #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions onnxscript/utils/replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,17 @@
import onnx_ir.passes.common as common_passes


def replace_functions(
model: onnx.ModelProto, functions: Sequence[onnx.FunctionProto]
) -> onnx.ModelProto:
def replace_functions_inplace(irmodel: ir.Model, irfunctions: Sequence[ir.Function]) -> None:
Copy link
Copy Markdown
Collaborator

@justinchuby justinchuby Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def replace_functions_inplace(irmodel: ir.Model, irfunctions: Sequence[ir.Function]) -> None:
def replace_functions_inplace(model: ir.Model, functions: Collection[ir.Function]) -> None:

Consider consistent names

"""A utility function to replace custom operations in a model with their expansions:

The model is updated in-place.

Args:
model: An ONNX ModelProto possibly containing calls to custom operations.
functions: A sequence of FunctionProto defining the expansions for the custom operations.
irmodel: An ONNX model possibly containing calls to custom operations.
irfunctions: A sequence of functions defining the expansions for the custom operations.


Returns:
An updated ModelProto with custom operations replaced by their expansions.
"""
irmodel = ir.from_proto(model)
irfunctions = [ir.from_proto(func) for func in functions]
model_functions = irmodel.functions
if len(model_functions) != 0:
# Since we use inlining, check that there are no model-local functions.
Expand All @@ -32,4 +30,20 @@ def replace_functions(
# TODO (rama): Ideally, we should provide users more control over renaming strategy for inlined values.
common_passes.InlinePass()(irmodel)
common_passes.RemoveUnusedOpsetsPass()(irmodel)


def replace_functions(
model: onnx.ModelProto, functions: Sequence[onnx.FunctionProto]
) -> onnx.ModelProto:
"""A utility function to replace custom operations in a model with their expansions:
Args:
model: An ONNX ModelProto possibly containing calls to custom operations.
functions: A sequence of FunctionProto defining the expansions for the custom operations.

Returns:
An updated ModelProto with custom operations replaced by their expansions.
"""
irmodel = ir.from_proto(model)
irfunctions = [ir.from_proto(func) for func in functions]
replace_functions_inplace(irmodel, irfunctions)
return ir.to_proto(irmodel)
Loading
⚡