fix(macos): <Text> with backgroundColor spills color past it's frame#2401
Merged
Saadnajmi merged 3 commits intomicrosoft:mainfrom Mar 7, 2025
Merged
fix(macos): <Text> with backgroundColor spills color past it's frame#2401Saadnajmi merged 3 commits intomicrosoft:mainfrom
Saadnajmi merged 3 commits intomicrosoft:mainfrom
Conversation
amgleitman
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For some odd reason, if you set
backgroundColoron a Text component, the color spills out past the frame to the parent. We can work around this by setting border radius... which somehow prevents this behavior. I need to debug the native side more (and may update this PR with a proper fix if I find one), but for now let's patch the JS to set a dummy value for borderRadius if we create a Text Element with backgroundColor and without borderRadiusTest Plan:
A bunch of examples in RNTester are now visible... like the "Recently Viewed" section.