Skip to content

fix(macos): <Text> with backgroundColor spills color past it's frame #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saadnajmi merged 3 commits into from
Mar 7, 2025
Merged

fix(macos): <Text> with backgroundColor spills color past it's frame #2401

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81f0087
fix(macos): <Text> with backgroundColor spills color past it's frame
Saadnajmi Mar 6, 2025
7a03097
use processedStyle + MIN_VALUE
Saadnajmi Mar 7, 2025
254158b
prettier
Saadnajmi Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/react-native/Libraries/Text/Text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,17 @@ const Text: component(
// $FlowFixMe[incompatible-type]
_style = [_style, overrides];
}

// [macOS
// For some reason, on macOS, Setting backgroundColor without borderRadius on Text will
// cause the color to spill pass the frame of the view. We can solve this by setting a dummy
// value for borderRadius.
if (Platform.OS === 'macos') {
if ('backgroundColor' in _style && !('borderRadius' in _style)) {
_style.borderRadius = 0.001;
Comment thread
Saadnajmi marked this conversation as resolved.
Outdated
}
}
// macOS]
}

const _nativeID = id ?? nativeID;
Expand Down
⚡