Remove Activate, Deactivate and Restart Revision Commands when not applicable #356
Merged
Remove Activate, Deactivate and Restart Revision Commands when not applicable #356
Conversation
MicroFish91
approved these changes
May 1, 2023
Member
|
boo |
Member
|
Discussed offline: Leverage the |
motm32
changed the title
Contributor
Author
|
Enablement does not work in this case so just removing the commands from view when they are not applicable. |
| iconPath: this.iconPath, | ||
| description, | ||
| contextValue: 'revision', | ||
| contextValue: `${this.revision.active ? 'active' : 'inactive'};revision`, |
Member
There was a problem hiding this comment.
The context value string should be created using the createContextValue util. It makes sure the values are sorted and deduped.
| label: this.revision.name, | ||
| iconPath: this.iconPath, | ||
| description, | ||
| contextValue: `${this.revision.active ? 'active' : 'inactive'};revision`, |
Member
There was a problem hiding this comment.
value passed to createContextValue should be like ['active', 'revision']. The util adds the ; too.
alexweininger
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163.
Fixes #322.