Skip to content

Remove Activate, Deactivate and Restart Revision Commands when not applicable #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motm32 merged 4 commits into from
May 4, 2023
Merged

Remove Activate, Deactivate and Restart Revision Commands when not applicable #356

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfd28d7
Activate revision if not active
motm32 Apr 28, 2023
bea340d
Remove commands when not applicable
motm32 May 3, 2023
939ba6a
Add createContextValue
motm32 May 4, 2023
8a1242b
More changes
motm32 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,17 +215,17 @@
},
{
"command": "containerApps.activateRevision",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|revision[^a-z]/i",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|^inactive;revision[^a-z]/i",
"group": "2@1"
},
{
"command": "containerApps.deactivateRevision",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|revision[^a-z]/i",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|^active;revision[^a-z]/i",
"group": "2@2"
},
{
"command": "containerApps.restartRevision",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|revision[^a-z]/i",
"when": "view == azureResourceGroups && viewItem =~ /revisionmode:single|^active;revision[^a-z]/i",
"group": "2@3"
},
{
Expand Down
4 changes: 2 additions & 2 deletions src/tree/RevisionItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import { KnownRevisionProvisioningState, Revision } from "@azure/arm-appcontainers";
import { nonNullProp, TreeItemIconPath } from "@microsoft/vscode-azext-utils";
import { TreeItemIconPath, createContextValue, nonNullProp } from "@microsoft/vscode-azext-utils";
import { AzureSubscription, ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
import { ThemeColor, ThemeIcon, TreeItem, TreeItemCollapsibleState } from "vscode";
import { localize } from "../utils/localize";
Expand Down Expand Up @@ -44,7 +44,7 @@ export class RevisionItem implements RevisionsItemModel {
label: this.revision.name,
iconPath: this.iconPath,
description,
contextValue: 'revision',
contextValue: createContextValue([`${this.revision.active ? 'active' : 'inactive'};revision`]),
collapsibleState: TreeItemCollapsibleState.Collapsed,
}
}
Expand Down
⚡