Skip to content

Reconfigure files and commands to fit the new revision management UI#390

Merged
MicroFish91 merged 3 commits intomainfrom
mwf/revision-draft-prep
Jun 15, 2023
Merged

Reconfigure files and commands to fit the new revision management UI#390
MicroFish91 merged 3 commits intomainfrom
mwf/revision-draft-prep

Conversation

@MicroFish91
Copy link
Copy Markdown
Contributor

@MicroFish91 MicroFish91 commented Jun 14, 2023

Builds on top of this work: #379

Closes #380

Summary of work:

  • Reorganized some files
  • Moved some of the revision commands off of the ContainerAppItem to the RevisionItem and RevisionsItem
  • Renamed/restructured revision context values
  • Add view properties to the newer ConfigurationItem
  • Add new Revision Management icon
  • Some minor related prep work for the upcoming revision draft PRs

const values: string[] = [RevisionItem.contextValue];

values.push(this.revision.active ? 'revisionState:active' : 'revisionState:inactive');
// values.push(ext.revisionDraftFileSystem.doesContainerAppsItemHaveRevisionDraft(this) ? 'revisionDraft:true' : 'revisionDraft:false');
Copy link
Copy Markdown
Contributor Author

@MicroFish91 MicroFish91 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreshadowing the upcoming work 😅

@MicroFish91 MicroFish91 marked this pull request as ready for review June 14, 2023 21:39
@MicroFish91 MicroFish91 requested a review from a team as a code owner June 14, 2023 21:39
@MicroFish91 MicroFish91 merged commit 6511189 into main Jun 15, 2023
@MicroFish91 MicroFish91 deleted the mwf/revision-draft-prep branch June 15, 2023 17:08
@microsoft microsoft locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconfigure revision commands to better fit into the new "revision management"-based UI

2 participants