Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -220,23 +220,23 @@
},
{
"command": "containerApps.chooseRevisionMode",
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionmode:single|revisions$/i",
"group": "2@4"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && (viewItem =~ /revisionItem(.*)revisionMode:single/i || viewItem =~ /revisionsItem/i)",
"group": "2@1"
},
{
"command": "containerApps.activateRevision",
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionmode:single|^inactive;revision[^a-z]/i",
"group": "2@1"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionItem(.*)revisionMode:multiple(.*)revisionState:inactive/i",
"group": "2@2"
},
{
"command": "containerApps.deactivateRevision",
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionmode:single|^active;revision[^a-z]/i",
"group": "2@2"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionItem(.*)revisionMode:multiple(.*)revisionState:active/i",
"group": "2@3"
},
{
"command": "containerApps.restartRevision",
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionmode:single|^active;revision[^a-z]/i",
"group": "2@3"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /revisionItem(.*)revisionState:active/i",
"group": "2@4"
},
{
"command": "containerApps.disableIngress",
Expand Down
29 changes: 29 additions & 0 deletions resources/02889-icon-menu-Container-Revision-Management.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/commands/ingress/editTargetPort/editTargetPort.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
*--------------------------------------------------------------------------------------------*/

import { AzureWizard, AzureWizardExecuteStep, AzureWizardPromptStep, createSubscriptionContext, IActionContext } from "@microsoft/vscode-azext-utils";
import { IngressItem } from "../../../tree/configurations/IngressItem";
import type { ContainerAppItem } from "../../../tree/ContainerAppItem";
import { IngressItem } from "../../../tree/IngressItem";
import { createActivityContext } from "../../../utils/activityUtils";
import { localize } from "../../../utils/localize";
import { pickContainerApp } from "../../../utils/pickContainerApp";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { Ingress } from "@azure/arm-appcontainers";
import { AzureWizard, AzureWizardExecuteStep, IActionContext, createSubscriptionContext, nonNullValueAndProp } from "@microsoft/vscode-azext-utils";
import { IngressConstants } from "../../../constants";
import type { ContainerAppItem } from "../../../tree/ContainerAppItem";
import type { IngressItem } from "../../../tree/IngressItem";
import type { IngressItem } from "../../../tree/configurations/IngressItem";
import { createActivityContext } from "../../../utils/activityUtils";
import { localize } from "../../../utils/localize";
import { pickContainerApp } from "../../../utils/pickContainerApp";
Expand Down
8 changes: 4 additions & 4 deletions src/commands/registerCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import { registerCommandWithTreeNodeUnwrapping, registerErrorHandler, registerReportIssueCommand } from '@microsoft/vscode-azext-utils';
import { browseContainerAppNode } from './browseContainerApp';
import { chooseRevisionMode } from './chooseRevisionMode';
import { createContainerApp } from './createContainerApp/createContainerApp';
import { createManagedEnvironment } from './createManagedEnvironment/createManagedEnvironment';
import { deleteContainerApp } from './deleteContainerApp/deleteContainerApp';
Expand All @@ -22,9 +21,10 @@ import { toggleIngressVisibility } from './ingress/toggleIngressVisibility/toggl
import { startStreamingLogs } from './logStream/startStreamingLogs';
import { stopStreamingLogs } from './logStream/stopStreamingLogs';
import { openConsoleInPortal } from './openConsoleInPortal';
import { activateRevision } from './revisionCommands/activateRevision';
import { deactivateRevision } from './revisionCommands/deactivateRevision';
import { restartRevision } from './revisionCommands/restartRevision';
import { activateRevision } from './revision/activateRevision';
import { chooseRevisionMode } from './revision/chooseRevisionMode';
import { deactivateRevision } from './revision/deactivateRevision';
import { restartRevision } from './revision/restartRevision';
import { addScaleRule } from './scaling/addScaleRule/addScaleRule';
import { editScalingRange } from './scaling/editScalingRange';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { IActionContext } from "@microsoft/vscode-azext-utils";
import { ContainerAppItem } from "../../tree/ContainerAppItem";
import { RevisionItem } from "../../tree/RevisionItem";
import type { IActionContext } from "@microsoft/vscode-azext-utils";
import type { RevisionItem } from "../../tree/revisionManagement/RevisionItem";
import { executeRevisionOperation } from "./changeRevisionActiveState";

export function activateRevision(context: IActionContext, node?: ContainerAppItem | RevisionItem): Promise<void> {
export function activateRevision(context: IActionContext, node?: RevisionItem): Promise<void> {
return executeRevisionOperation(context, node, 'activateRevision');
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@
import { ContainerAppsAPIClient } from "@azure/arm-appcontainers";
import { IActionContext, nonNullProp } from "@microsoft/vscode-azext-utils";
import { ext } from "../../extensionVariables";
import { ContainerAppItem } from "../../tree/ContainerAppItem";
import { RevisionItem } from "../../tree/RevisionItem";
import { RevisionItem } from "../../tree/revisionManagement/RevisionItem";
import { createContainerAppsClient } from "../../utils/azureClients";
import { localize } from "../../utils/localize";
import { pickContainerApp } from "../../utils/pickContainerApp";

export async function executeRevisionOperation(context: IActionContext, node: ContainerAppItem | RevisionItem | undefined, operation: RevisionOperation): Promise<void> {
export async function executeRevisionOperation(context: IActionContext, node: RevisionItem | undefined, operation: RevisionOperation): Promise<void> {
const item = node ?? await pickContainerApp(context);

await ext.state.runWithTemporaryDescription(item.id, revisionOperationDescriptions[operation], async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@
*--------------------------------------------------------------------------------------------*/

import { KnownActiveRevisionsMode } from "@azure/arm-appcontainers";
import { IActionContext, IAzureQuickPickItem } from "@microsoft/vscode-azext-utils";
import type { IActionContext, IAzureQuickPickItem } from "@microsoft/vscode-azext-utils";
import { ProgressLocation, window } from "vscode";
import { ext } from "../extensionVariables";
import { ContainerAppModel } from "../tree/ContainerAppItem";
import { ContainerAppsItem } from "../tree/ContainerAppsBranchDataProvider";
import { localize } from "../utils/localize";
import { pickContainerApp } from "../utils/pickContainerApp";
import { updateContainerApp } from "./deployContainerApp/updateContainerApp";

export async function chooseRevisionMode(context: IActionContext, node?: ContainerAppsItem): Promise<void> {
import { ext } from "../../extensionVariables";
import type { ContainerAppModel } from "../../tree/ContainerAppItem";
import type { RevisionsItem } from "../../tree/revisionManagement/RevisionsItem";
import { localize } from "../../utils/localize";
import { pickContainerApp } from "../../utils/pickContainerApp";
import { updateContainerApp } from "../deployContainerApp/updateContainerApp";

export async function chooseRevisionMode(context: IActionContext, node?: RevisionsItem): Promise<void> {
const { subscription, containerApp } = node ?? await pickContainerApp(context);

const pickedRevisionMode = await pickRevisionsMode(context, containerApp);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext } from "@microsoft/vscode-azext-utils";
import { ContainerAppItem } from "../../tree/ContainerAppItem";
import { RevisionItem } from "../../tree/RevisionItem";
import { RevisionItem } from "../../tree/revisionManagement/RevisionItem";
import { executeRevisionOperation } from "./changeRevisionActiveState";

export function deactivateRevision(context: IActionContext, node?: ContainerAppItem | RevisionItem): Promise<void> {
export function deactivateRevision(context: IActionContext, node?: RevisionItem): Promise<void> {
return executeRevisionOperation(context, node, 'deactivateRevision');
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext } from "@microsoft/vscode-azext-utils";
import { ContainerAppItem } from "../../tree/ContainerAppItem";
import { RevisionItem } from "../../tree/RevisionItem";
import { RevisionItem } from "../../tree/revisionManagement/RevisionItem";
import { executeRevisionOperation } from "./changeRevisionActiveState";

export function restartRevision(context: IActionContext, node?: ContainerAppItem | RevisionItem): Promise<void> {
export function restartRevision(context: IActionContext, node?: RevisionItem): Promise<void> {
return executeRevisionOperation(context, node, 'restartRevision');
}
6 changes: 3 additions & 3 deletions src/tree/ContainerAppItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ import { createContainerAppsAPIClient, createContainerAppsClient } from "../util
import { createPortalUrl } from "../utils/createPortalUrl";
import { localize } from "../utils/localize";
import { treeUtils } from "../utils/treeUtils";
import { ConfigurationItem } from "./ConfigurationItem";
import { ContainerAppsItem, TreeElementBase } from "./ContainerAppsBranchDataProvider";
import { LogsItem } from "./LogsItem";
import { RevisionItem } from "./RevisionItem";
import { RevisionsItem } from "./RevisionsItem";
import { ConfigurationItem } from "./configurations/ConfigurationItem";
import { RevisionItem } from "./revisionManagement/RevisionItem";
import { RevisionsItem } from "./revisionManagement/RevisionsItem";

export interface ContainerAppModel extends ContainerApp {
id: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { callWithTelemetryAndErrorHandling } from "@microsoft/vscode-azext-utils";
import { AzureSubscription } from "@microsoft/vscode-azureresources-api";
import { callWithTelemetryAndErrorHandling, nonNullProp } from "@microsoft/vscode-azext-utils";
import { AzureSubscription, ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
import { ThemeIcon, TreeItem, TreeItemCollapsibleState } from "vscode";
import { localize } from "../utils/localize";
import { ContainerAppModel } from "./ContainerAppItem";
import { ContainerAppsItem, TreeElementBase } from "./ContainerAppsBranchDataProvider";
import { localize } from "../../utils/localize";
import { ContainerAppModel } from "../ContainerAppItem";
import { ContainerAppsItem, TreeElementBase } from "../ContainerAppsBranchDataProvider";
import { ActionsTreeItem } from "../gitHub/ActionsTreeItem";
import { DaprEnabledItem, createDaprDisabledItem } from "./DaprItem";
import { IngressDisabledItem, IngressItem } from "./IngressItem";
import { ActionsTreeItem } from "./gitHub/ActionsTreeItem";

const configuration: string = localize('configuration', 'Configuration');

export class ConfigurationItem implements ContainerAppsItem {
id: string;
Expand All @@ -21,6 +23,11 @@ export class ConfigurationItem implements ContainerAppsItem {
this.id = `${containerApp.id}/Configurations`;
}

viewProperties: ViewPropertiesModel = {
data: nonNullProp(this.containerApp, 'configuration'),
label: `${this.containerApp.name} ${configuration}`,
}

async getChildren(): Promise<TreeElementBase[]> {
const result = await callWithTelemetryAndErrorHandling('getChildren', async (_context) => {
const children: TreeElementBase[] = [];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import { ContainerApp, Dapr } from "@azure/arm-appcontainers";
import { createGenericElement } from "@microsoft/vscode-azext-utils";
import { ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
import { ThemeIcon, TreeItem, TreeItemCollapsibleState } from "vscode";
import { localize } from "../utils/localize";
import { treeUtils } from "../utils/treeUtils";
import { ContainerAppModel } from "./ContainerAppItem";
import { TreeElementBase } from "./ContainerAppsBranchDataProvider";
import { localize } from "../../utils/localize";
import { treeUtils } from "../../utils/treeUtils";
import { ContainerAppModel } from "../ContainerAppItem";
import { TreeElementBase } from "../ContainerAppsBranchDataProvider";

export class DaprEnabledItem implements TreeElementBase {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import { ContainerApp, Ingress } from "@azure/arm-appcontainers";
import { createGenericElement } from "@microsoft/vscode-azext-utils";
import { AzureSubscription, ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
import { ThemeIcon, TreeItem, TreeItemCollapsibleState } from "vscode";
import { IngressConstants, azResourceContextValue } from "../constants";
import { localize } from "../utils/localize";
import { treeUtils } from "../utils/treeUtils";
import { ContainerAppModel } from "./ContainerAppItem";
import { ContainerAppsItem, TreeElementBase } from "./ContainerAppsBranchDataProvider";
import { IngressConstants, azResourceContextValue } from "../../constants";
import { localize } from "../../utils/localize";
import { treeUtils } from "../../utils/treeUtils";
import { ContainerAppModel } from "../ContainerAppItem";
import { ContainerAppsItem, TreeElementBase } from "../ContainerAppsBranchDataProvider";

const label: string = localize('ingress', 'Ingress');

Expand Down
Loading