Skip to content

Fix activity log wording to include ingress visibility (external/internal)#958

Merged
MicroFish91 merged 4 commits intomainfrom
copilot/fix-954
Oct 30, 2025
Merged

Fix activity log wording to include ingress visibility (external/internal)#958
MicroFish91 merged 4 commits intomainfrom
copilot/fix-954

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Aug 20, 2025

The activity log and output log were showing inconsistent wording when enabling ingress for a container app. The activity log was displaying generic "Enable ingress" messages while the output log correctly specified whether it was "external ingress" or "internal ingress".

Before this fix:

  • Activity log: "Enable ingress on port 5002 for container app 'serene-app'"
  • Output log: "Successfully enabled external ingress on port 5002."

After this fix:

  • Activity log: "Enable external ingress on port 5002 for container app 'serene-app'"
  • Output log: "Successfully enabled external ingress on port 5002."

The fix adds visibility determination logic to the activity title generation in enableIngress.ts, following the same pattern already used in EnableIngressStep.ts for output log messages. This ensures consistent terminology across both logging mechanisms.

// Added visibility determination
const visibility: string = wizardContext.enableExternal ? localize('external', 'external') : localize('internal', 'internal');
wizardContext.activityTitle = localize('enableIngressWithVisibility', 'Enable {0} ingress on port {1} for container app "{2}"', visibility, wizardContext.targetPort, containerApp.name);

Fixes #954.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: node ./dist/test/runTest.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits August 20, 2025 18:34
Co-authored-by: nturinski <5290572+nturinski@users.noreply.github.com>
Co-authored-by: nturinski <5290572+nturinski@users.noreply.github.com>
Copilot AI changed the title [WIP] Activity log wording does not align with output log when enabling ingress Fix activity log wording to include ingress visibility (external/internal) Aug 20, 2025
Copilot AI requested a review from nturinski August 20, 2025 18:42
@MicroFish91
Copy link
Copy Markdown
Contributor

@copilot do not make any changes to files that are outside of src/commands/ingress/enableIngress/enableIngress.ts, they are not necessary for this fix

Co-authored-by: MicroFish91 <40250218+MicroFish91@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Aug 21, 2025

@copilot do not make any changes to files that are outside of src/commands/ingress/enableIngress/enableIngress.ts, they are not necessary for this fix

Done! I've reverted all changes to files outside of src/commands/ingress/enableIngress/enableIngress.ts. The unnecessary modifications to main.js, package.json, and package-lock.json have been removed while preserving the core fix for the activity log wording. (commit 59355d2)

@MicroFish91 MicroFish91 marked this pull request as ready for review August 25, 2025 17:24
@MicroFish91 MicroFish91 requested a review from a team as a code owner August 25, 2025 17:24
@MicroFish91 MicroFish91 merged commit 063ff3b into main Oct 30, 2025
2 checks passed
@MicroFish91 MicroFish91 deleted the copilot/fix-954 branch October 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity log wording does not align with output log when enabling ingress

4 participants