Fix activity log wording to include ingress visibility (external/internal)#958
Merged
MicroFish91 merged 4 commits intomainfrom Oct 30, 2025
Merged
Fix activity log wording to include ingress visibility (external/internal)#958MicroFish91 merged 4 commits intomainfrom
MicroFish91 merged 4 commits intomainfrom
Conversation
Co-authored-by: nturinski <5290572+nturinski@users.noreply.github.com>
Co-authored-by: nturinski <5290572+nturinski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Activity log wording does not align with output log when enabling ingress
Fix activity log wording to include ingress visibility (external/internal)
Aug 20, 2025
Contributor
|
@copilot do not make any changes to files that are outside of |
Co-authored-by: MicroFish91 <40250218+MicroFish91@users.noreply.github.com>
Contributor
Author
Done! I've reverted all changes to files outside of |
MicroFish91
approved these changes
Aug 23, 2025
nturinski
approved these changes
Aug 26, 2025
alexweininger
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The activity log and output log were showing inconsistent wording when enabling ingress for a container app. The activity log was displaying generic "Enable ingress" messages while the output log correctly specified whether it was "external ingress" or "internal ingress".
Before this fix:
After this fix:
The fix adds visibility determination logic to the activity title generation in
enableIngress.ts, following the same pattern already used inEnableIngressStep.tsfor output log messages. This ensures consistent terminology across both logging mechanisms.Fixes #954.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.comnode ./dist/test/runTest.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.