Skip to content

Fix activity log wording to include ingress visibility (external/internal) #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicroFish91 merged 4 commits into from
Oct 30, 2025
Merged

Fix activity log wording to include ingress visibility (external/internal) #958

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7bf622
Initial plan
Copilot Aug 20, 2025
dfc4391
Initial plan for fixing activity log wording inconsistency
Copilot Aug 20, 2025
efcd9d5
Fix activity log wording to include visibility (external/internal)
Copilot Aug 20, 2025
59355d2
Remove unnecessary changes outside of enableIngress.ts
Copilot Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/commands/ingress/enableIngress/enableIngress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ export async function enableIngress(context: IActionContext, node?: ContainerApp
});

await wizard.prompt();
wizardContext.activityTitle = localize('enableIngress', 'Enable ingress on port {0} for container app "{1}"', wizardContext.targetPort, containerApp.name);
const visibility: string = wizardContext.enableExternal ? localize('external', 'external') : localize('internal', 'internal');
wizardContext.activityTitle = localize('enableIngressWithVisibility', 'Enable {0} ingress on port {1} for container app "{2}"', visibility, wizardContext.targetPort, containerApp.name);
await wizard.execute();

ext.state.notifyChildrenChanged(containerApp.managedEnvironmentId);
Expand Down
⚡