utils: Fix commands that are run on non-subscription related AzExtTreeItem's#1918
Merged
alexweininger merged 3 commits intomainfrom Mar 7, 2025
Merged
utils: Fix commands that are run on non-subscription related AzExtTreeItem's#1918alexweininger merged 3 commits intomainfrom
alexweininger merged 3 commits intomainfrom
Conversation
bwateratmsft
approved these changes
Mar 7, 2025
This was referenced Mar 7, 2025
alexweininger
added a commit
to microsoft/vscode-azurestorage
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azureappservice
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurestaticwebapps
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurecontainerapps
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurevirtualmachines
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurevirtualmachines
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurecontainerapps
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurestaticwebapps
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azurestorage
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
alexweininger
added a commit
to microsoft/vscode-azureappservice
that referenced
this pull request
Mar 7, 2025
Consume utils v2.6.3 https://github.com/microsoft/vscode-azuretools/releases/tag/microsoft-vscode-azext-utils-v2.6.3 Read more about the cause of the issue in microsoft/vscode-azuretools#1918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing the subscription property on AzExtTreeItems throws if the items don't have subscriptions. Which happens for tree items in the Help & Feedback view, and in a few other places. The fix is to add try/catches around any place where this property is accessed for telemetry's sake. It's not pretty but it's what we have to do.
Related issues: microsoft/vscode-azureresourcegroups#1080, microsoft/vscode-azureresourcegroups#1081, and microsoft/vscode-azurefunctions#4402