appservice: Use reserved from list response for EP/WS plan OS detection#2229
Merged
alexweininger merged 2 commits intomainfrom Mar 19, 2026
Merged
appservice: Use reserved from list response for EP/WS plan OS detection#2229alexweininger merged 2 commits intomainfrom
alexweininger merged 2 commits intomainfrom
Conversation
Remove per-plan GET requests for Elastic Premium and Workflow Standard plans when determining Linux vs Windows OS. The `reserved` property is now correctly returned by the list operation as of API version 2024-11-01+. The current SDK (@azure/arm-appservice v18.0.0) uses API version 2025-03-01. This eliminates N+1 API calls that could cause multi-minute delays when users have many EP/WS app service plans. Fixes #2129 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves App Service Plan OS detection for Elastic Premium (EP) and Workflow Standard (WS) plans by using the reserved flag from the list response instead of issuing a separate GET request per plan, eliminating significant quick pick load delays (fixes #2129).
Changes:
- Removed per-plan
tryGetAppServicePlanGET calls for EP/WS plans during quick pick population. - Switched EP/WS OS detection logic to rely on
plan.reservedfrom the list response.
Files not reviewed (1)
- appservice/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bwateratmsft
approved these changes
Mar 19, 2026
Member
Author
|
Released in appservice v4.2.2 |
This was referenced Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listing App Service Plans for the quick pick, EP (Elastic Premium) and WS (Workflow Standard) plans don't include the OS in their
kindstring, so we check thereservedproperty instead. The old code did a separate GET request for every single EP/WS plan to fetch this, which caused multi-minute delays for users with many plans (see #2129).As Brandon found in #2129 (comment),
reservedis now correctly returned by the list operation as of API version2024-11-01. Our SDK (@azure/arm-appservicev18.0.0) uses2025-03-01, so we can just readplan.reserveddirectly — no extra queries needed.Fixes #2129