Skip to content

appservice: Use reserved from list response for EP/WS plan OS detection #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexweininger merged 2 commits into from
Mar 19, 2026
Merged

appservice: Use reserved from list response for EP/WS plan OS detection #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c99b0eb
appservice: Use reserved from list response for EP/WS plans
alexweininger Mar 19, 2026
2326009
bump version to 4.2.2
alexweininger Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appservice/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion appservice/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@microsoft/vscode-azext-azureappservice",
"author": "Microsoft Corporation",
"version": "4.2.1",
"version": "4.2.2",
"description": "Common tools for developing Azure App Service extensions for VS Code",
"tags": [
"azure",
Expand Down
10 changes: 4 additions & 6 deletions appservice/src/createAppService/AppServicePlanListStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { AzExtLocation, LocationListStep, ResourceGroupListStep, uiUtils } from
import { AzureWizardPromptStep, IAzureQuickPickItem, IAzureQuickPickOptions, IWizardOptions, nonNullProp } from '@microsoft/vscode-azext-utils';
import * as vscode from 'vscode';
import { webProvider } from '../constants';
import { tryGetAppServicePlan } from '../tryGetSiteResource';
import { createWebSiteClient } from '../utils/azureClients';
import { AppKind, getWebsiteOSDisplayName, WebsiteOS } from './AppKind';
import { AppServicePlanCreateStep } from './AppServicePlanCreateStep';
Expand Down Expand Up @@ -104,11 +103,10 @@ export class AppServicePlanListStep extends AzureWizardPromptStep<IAppServiceWiz
let isPlanLinux: boolean = nonNullProp(plan, 'kind').toLowerCase().includes(WebsiteOS.linux);

if (plan.sku && (plan.sku.family === 'EP' || plan.sku.family === 'WS')) {
// elastic premium plans and workflow standard plans do not have the os in the kind, so we have to check the "reserved" property
// also, the "reserved" property is always "false" in the list of plans returned above. We have to perform a separate get on each plan
const client: WebSiteManagementClient = await createWebSiteClient(context);
const epPlan: AppServicePlan | undefined = await tryGetAppServicePlan(client, nonNullProp(plan, 'resourceGroup'), nonNullProp(plan, 'name'));
isPlanLinux = !!epPlan?.reserved;
// Elastic premium and workflow standard plans do not have the OS in the `kind` string,
// so we check the `reserved` property instead. As of API version 2024-11-01+, `reserved`
// is correctly returned by the list operation (no extra per-plan GET needed).
isPlanLinux = !!plan.reserved;
}

// plan.kind will contain "linux" for Linux plans, but will _not_ contain "windows" for Windows plans. Thus we check "isLinux" for both cases
Expand Down
Loading
⚡