Skip to content

Fix release metro plan on OpenRewrite shows everything as circluar#102

Open
sambsnyd wants to merge 1 commit intomainfrom
tests-arent-circular
Open

Fix release metro plan on OpenRewrite shows everything as circluar#102
sambsnyd wants to merge 1 commit intomainfrom
tests-arent-circular

Conversation

@sambsnyd
Copy link
Copy Markdown
Member

@sambsnyd sambsnyd commented May 4, 2026

I believe the confusion is related to test dependencies, so I'm filtering those out for ordering purposes

…the are not. I believe the confusion is related to test dependencies, so I'm filtering those out for ordering purposes
@MBoegers
Copy link
Copy Markdown
Contributor

MBoegers commented May 5, 2026

Hey Sam — I built on top of this in #103. Diagnosing cycles on the moderneinc + OpenRewrite extracts I noticed DependenciesDeclared emits the declared scope strings rather than resolved Maven scopes, so the allowlist here drops almost every Gradle row (implementation 1432 → 0, api 166 → 0, compileOnly 173 → 0, runtimeOnly 108 → 0). I cherry-picked your commit and extended _RELEASE_SCOPES to cover the Gradle declared configurations as part of #103, where I also switch the metro specs/notebooks to DependenciesDeclared. Happy to leave this open and close it as superseded once #103 lands, or feel free to grab the allowlist extension and merge here first — your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants