feat: switch release metro viz to DependenciesDeclared (incorporates #102)#103
Open
feat: switch release metro viz to DependenciesDeclared (incorporates #102)#103
Conversation
…the are not. I believe the confusion is related to test dependencies, so I'm filtering those out for ordering purposes
- Specs and notebooks now consume DependenciesDeclared (declared-only, Maven + Gradle) in place of DependenciesInUse - Extend _RELEASE_SCOPES from #102 with Gradle declared configurations (implementation, api, compileOnly, compileOnlyApi, runtimeOnly, annotationProcessor, classpath) — the table emits raw declared scope strings, so the Maven-resolved allowlist dropped most rows - Secondary tables now use pd.read_csv(comment="#") to handle v2 header lines without colliding with NB_DATA_TABLE - Refresh samples/v2/ with Moderne Training extracts; drop orphaned v1 metro CSVs
Contributor
Author
|
OR+Moderne now is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.openrewrite.java.dependencies.table.DependenciesDeclared, replacing the deprecatedorg.openrewrite.maven.table.DependenciesInUse. The new table is emitted byFindDependenciesand lists declared (non-transitive) deps for both Maven and Gradle projects._RELEASE_SCOPESto cover the Gradle declared configurations thatDependenciesDeclaredemits verbatim:implementation,api,compileOnly,compileOnlyApi,runtimeOnly,annotationProcessor,classpath. Without that extension Sam's allowlist (which was built around resolved Maven scopes) drops ~98% of Gradle rows and leaves the graph nearly empty.pd.read_csv(..., comment="#")so v2 header lines are tolerated without going through thedt.read_csvpath that gets hijacked byNB_DATA_TABLE.samples/v2/with extracts from the Moderne Training org and drops the orphaned v1 metro CSVs.Effect on cycles (moderneinc + OpenRewrite sample)
main)| this PR (extended allowlist) | 381 | 14 | 0 |
Test plan
poe check-optionsandpoe check-allpasssamples/v2/Moderne Training extracts and inspect the generated HTML