Skip to content

Fix: DSP edge cases around groups#1879

Merged
marcelveldt merged 4 commits into
music-assistant:devfrom
maximmaxim345:fix/dsp-edge-cases
Jan 16, 2025
Merged

Fix: DSP edge cases around groups#1879
marcelveldt merged 4 commits into
music-assistant:devfrom
maximmaxim345:fix/dsp-edge-cases

Conversation

@maximmaxim345

Copy link
Copy Markdown
Member

This PR fixes various edge cases I missed with #1839.

Reload Detection

The existing logic for issuing DSP reloads when grouping or ungrouping was flawed.
This reworks this section, handling all edge cases I can think of including:

  • Don't restart playback if the leader already had DSP disabled
  • Don't restart playback if a group shrank to a single device that has DSP disabled
  • Proper handling of PlayerGroups
  • PlayerGroup with only a single member

Additionally, the existing logic had another oversight where it would issue a reload command for every device in the group. This fixes that by only reloading the leader/PlayerGroup.

PlayerGroups with single members

Another previously missed edge case involves groups with single members that would mistakenly use the DSP Config of the PlayerGroup instead of the Player. This is now fixed.

This now allows all PlayerGroups with single devices to correctly apply DSP.

@marcelveldt

Copy link
Copy Markdown
Member

The linter found something - maybe add an exclusion to that function for now, it complains about too many statements.
Something for later times is trying to split all that up into smaller parts but not a prio for now.

@marcelveldt marcelveldt merged commit 3b4304f into music-assistant:dev Jan 16, 2025
@maximmaxim345 maximmaxim345 deleted the fix/dsp-edge-cases branch January 17, 2025 07:34
github-actions Bot pushed a commit that referenced this pull request Jun 8, 2026
Update music-assistant-frontend to version
[2.17.181](https://github.com/music-assistant/frontend/releases/tag/2.17.181)


- Fix queue items disappearing in fullscreen player (by @MarvinSchenkel
in [#1874](music-assistant/frontend#1874))
- Add translation key for now playing badge (by @MarvinSchenkel in
[#1889](music-assistant/frontend#1889))

## 🚀 Features and enhancements

- Refactor heart icon and add it to the artist page (by @stvncode in
[#1891](music-assistant/frontend#1891))
- Add back subtitle for discover page (by @stvncode in
[#1890](music-assistant/frontend#1890))
- Bigger tiles on mobile (by @stvncode in
[#1887](music-assistant/frontend#1887))

## 🐛 Bugfixes

- Fix self-sustaining WebRTC reconnect storm in remote transport (by
@MarvinSchenkel in
[#1888](music-assistant/frontend#1888))
- Subtle placeholder for both dark and light mode (by @stvncode in
[#1886](music-assistant/frontend#1886))

## 🧰 Maintenance and dependency bumps

<details>
<summary>8 changes</summary>

- Add built-in playlists for favorites and random tracks (by @OzGav in
[#1876](music-assistant/frontend#1876))
- Chore(deps): Bump ludeeus/action-require-labels from 1.1.0 to 2.0.0
(by @[dependabot[bot]](https://github.com/apps/dependabot) in
[#1878](music-assistant/frontend#1878))
- Chore(deps): Bump happy-dom from 20.9.0 to 20.10.2 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1879](music-assistant/frontend#1879))
- Chore(deps): Bump marked from 18.0.3 to 18.0.5 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1880](music-assistant/frontend#1880))
- Chore(deps-dev): Bump @types/node from 25.9.1 to 25.9.2 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1881](music-assistant/frontend#1881))
- Chore(deps): Bump @tanstack/vue-form from 1.32.0 to 1.33.0 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1882](music-assistant/frontend#1882))
- Chore(deps): Bump vue-i18n from 11.4.4 to 11.4.5 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1883](music-assistant/frontend#1883))
- Chore(deps): Bump reka-ui from 2.9.8 to 2.9.9 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[#1884](music-assistant/frontend#1884))
</details>


## 🙇 Contributors

@MarvinSchenkel, @OzGav and @stvncode

Co-authored-by: stvncode <25082266+stvncode@users.noreply.github.com>
anatosun pushed a commit to anatosun/music-assistant-server that referenced this pull request Jun 14, 2026
Update music-assistant-frontend to version
[2.17.181](https://github.com/music-assistant/frontend/releases/tag/2.17.181)


- Fix queue items disappearing in fullscreen player (by @MarvinSchenkel
in [music-assistant#1874](music-assistant/frontend#1874))
- Add translation key for now playing badge (by @MarvinSchenkel in
[music-assistant#1889](music-assistant/frontend#1889))

## 🚀 Features and enhancements

- Refactor heart icon and add it to the artist page (by @stvncode in
[music-assistant#1891](music-assistant/frontend#1891))
- Add back subtitle for discover page (by @stvncode in
[music-assistant#1890](music-assistant/frontend#1890))
- Bigger tiles on mobile (by @stvncode in
[music-assistant#1887](music-assistant/frontend#1887))

## 🐛 Bugfixes

- Fix self-sustaining WebRTC reconnect storm in remote transport (by
@MarvinSchenkel in
[music-assistant#1888](music-assistant/frontend#1888))
- Subtle placeholder for both dark and light mode (by @stvncode in
[music-assistant#1886](music-assistant/frontend#1886))

## 🧰 Maintenance and dependency bumps

<details>
<summary>8 changes</summary>

- Add built-in playlists for favorites and random tracks (by @OzGav in
[music-assistant#1876](music-assistant/frontend#1876))
- Chore(deps): Bump ludeeus/action-require-labels from 1.1.0 to 2.0.0
(by @[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1878](music-assistant/frontend#1878))
- Chore(deps): Bump happy-dom from 20.9.0 to 20.10.2 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1879](music-assistant/frontend#1879))
- Chore(deps): Bump marked from 18.0.3 to 18.0.5 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1880](music-assistant/frontend#1880))
- Chore(deps-dev): Bump @types/node from 25.9.1 to 25.9.2 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1881](music-assistant/frontend#1881))
- Chore(deps): Bump @tanstack/vue-form from 1.32.0 to 1.33.0 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1882](music-assistant/frontend#1882))
- Chore(deps): Bump vue-i18n from 11.4.4 to 11.4.5 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1883](music-assistant/frontend#1883))
- Chore(deps): Bump reka-ui from 2.9.8 to 2.9.9 (by
@[dependabot[bot]](https://github.com/apps/dependabot) in
[music-assistant#1884](music-assistant/frontend#1884))
</details>


## 🙇 Contributors

@MarvinSchenkel, @OzGav and @stvncode

Co-authored-by: stvncode <25082266+stvncode@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants