FIX: Audiobookshelf - use non admin user endpoint + wrong login credentials#1883
Merged
marcelveldt merged 3 commits intoJan 17, 2025
Merged
Conversation
fmunkes
changed the title
1 task
fmunkes
changed the title
Contributor
Author
|
Ok, so when a user uses credentials which are not ok, this is correctly reported. However, I nevertheless have -> this is somehow resolved by allowing multiple instances, which in the case of abs is fine. However, I would expect, that a failed setup would not 'count' as an instance. I will not add another commit besides 5515726 to this PR, just let me know, if you think this is fine or not. |
fixes my comment on second part of [music-assistant#3471](music-assistant/support#3471) and multiple instances of abs are fine.
Contributor
|
While maybe niche I do think it makes sense for ABS to be multi instance. |
Member
|
I'll look into the single instance issue, that appears to be a bug in the config controller. |
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
Update music-assistant-frontend to version [2.17.181](https://github.com/music-assistant/frontend/releases/tag/2.17.181) - Fix queue items disappearing in fullscreen player (by @MarvinSchenkel in [#1874](music-assistant/frontend#1874)) - Add translation key for now playing badge (by @MarvinSchenkel in [#1889](music-assistant/frontend#1889)) ## 🚀 Features and enhancements - Refactor heart icon and add it to the artist page (by @stvncode in [#1891](music-assistant/frontend#1891)) - Add back subtitle for discover page (by @stvncode in [#1890](music-assistant/frontend#1890)) - Bigger tiles on mobile (by @stvncode in [#1887](music-assistant/frontend#1887)) ## 🐛 Bugfixes - Fix self-sustaining WebRTC reconnect storm in remote transport (by @MarvinSchenkel in [#1888](music-assistant/frontend#1888)) - Subtle placeholder for both dark and light mode (by @stvncode in [#1886](music-assistant/frontend#1886)) ## 🧰 Maintenance and dependency bumps <details> <summary>8 changes</summary> - Add built-in playlists for favorites and random tracks (by @OzGav in [#1876](music-assistant/frontend#1876)) - Chore(deps): Bump ludeeus/action-require-labels from 1.1.0 to 2.0.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1878](music-assistant/frontend#1878)) - Chore(deps): Bump happy-dom from 20.9.0 to 20.10.2 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1879](music-assistant/frontend#1879)) - Chore(deps): Bump marked from 18.0.3 to 18.0.5 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1880](music-assistant/frontend#1880)) - Chore(deps-dev): Bump @types/node from 25.9.1 to 25.9.2 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1881](music-assistant/frontend#1881)) - Chore(deps): Bump @tanstack/vue-form from 1.32.0 to 1.33.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1882](music-assistant/frontend#1882)) - Chore(deps): Bump vue-i18n from 11.4.4 to 11.4.5 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1883](music-assistant/frontend#1883)) - Chore(deps): Bump reka-ui from 2.9.8 to 2.9.9 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#1884](music-assistant/frontend#1884)) </details> ## 🙇 Contributors @MarvinSchenkel, @OzGav and @stvncode Co-authored-by: stvncode <25082266+stvncode@users.noreply.github.com>
anatosun
pushed a commit
to anatosun/music-assistant-server
that referenced
this pull request
Jun 14, 2026
Update music-assistant-frontend to version [2.17.181](https://github.com/music-assistant/frontend/releases/tag/2.17.181) - Fix queue items disappearing in fullscreen player (by @MarvinSchenkel in [music-assistant#1874](music-assistant/frontend#1874)) - Add translation key for now playing badge (by @MarvinSchenkel in [music-assistant#1889](music-assistant/frontend#1889)) ## 🚀 Features and enhancements - Refactor heart icon and add it to the artist page (by @stvncode in [music-assistant#1891](music-assistant/frontend#1891)) - Add back subtitle for discover page (by @stvncode in [music-assistant#1890](music-assistant/frontend#1890)) - Bigger tiles on mobile (by @stvncode in [music-assistant#1887](music-assistant/frontend#1887)) ## 🐛 Bugfixes - Fix self-sustaining WebRTC reconnect storm in remote transport (by @MarvinSchenkel in [music-assistant#1888](music-assistant/frontend#1888)) - Subtle placeholder for both dark and light mode (by @stvncode in [music-assistant#1886](music-assistant/frontend#1886)) ## 🧰 Maintenance and dependency bumps <details> <summary>8 changes</summary> - Add built-in playlists for favorites and random tracks (by @OzGav in [music-assistant#1876](music-assistant/frontend#1876)) - Chore(deps): Bump ludeeus/action-require-labels from 1.1.0 to 2.0.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1878](music-assistant/frontend#1878)) - Chore(deps): Bump happy-dom from 20.9.0 to 20.10.2 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1879](music-assistant/frontend#1879)) - Chore(deps): Bump marked from 18.0.3 to 18.0.5 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1880](music-assistant/frontend#1880)) - Chore(deps-dev): Bump @types/node from 25.9.1 to 25.9.2 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1881](music-assistant/frontend#1881)) - Chore(deps): Bump @tanstack/vue-form from 1.32.0 to 1.33.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1882](music-assistant/frontend#1882)) - Chore(deps): Bump vue-i18n from 11.4.4 to 11.4.5 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1883](music-assistant/frontend#1883)) - Chore(deps): Bump reka-ui from 2.9.8 to 2.9.9 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [music-assistant#1884](music-assistant/frontend#1884)) </details> ## 🙇 Contributors @MarvinSchenkel, @OzGav and @stvncode Co-authored-by: stvncode <25082266+stvncode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3471
I just tested everything with non-admin users. The endpoint used appeared to be the only one where an admin user is strictly required. Will make sure in following PRs to also use a non-admin user for testing.