Apply better support info for Verdaccio 4#38
Merged
n4bb12 merged 8 commits inton4bb12:masterfrom Nov 22, 2019
pmmmwh:better-support-info
Merged
Apply better support info for Verdaccio 4#38n4bb12 merged 8 commits inton4bb12:masterfrom pmmmwh:better-support-info
n4bb12 merged 8 commits inton4bb12:masterfrom
pmmmwh:better-support-info
Conversation
n4bb12
previously approved these changes
Nov 20, 2019
Owner
Contributor
Author
I think that is a bug on Verdaccio's side. This function here uses I filed a PR upstream here Edit: Oops, I discovered a bug - I will fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi! I really appreciate the work done in this plugin and we are currently using this for our own private registry. However - we realized a few things that are misleading to the users. This PR aims to fix that presentation issue so that the registration of the GitHub OAuth flow is easier.
Patches applied in the PR:
expressas a dependency instead of a peer dependency because the CLI needs it (npxwill not installdevDependenciesnorpeerDependencies)VERDACCIO_API_URLso that clicking for info in the package page won't get the wrong URLnpmas is, also forpnpmandyarn)