fix: correctly reference registry url from options

[pmmmwh]

Type: Bug Fix

Description:

Currently, the repository URL is not being correctly referenced in the Registry Info dialog if the web UI is not loaded at root. This is discovered and illustrated here. This PR uses window.__VERDACCIO_UI_OPTIONS to correctly get the base url so that loading will not affect the display of info.

[juanpicado]

Thank u so much for this !

[anikethsaha]

Looks good 👍

[juanpicado]

Only test are failing

[anikethsaha]

I think tests need to be updated.

registry URL should not contain the path, right?

• http://localhost/-/web/detail is not a registry URL.
• http://localhost it is

cc @juanpicado , what do you think ?

[priscilawebdev]

thanks for your contribution @pmmmwh :)

Unfortunately tests are failing..

[pmmmwh]

thanks for your contribution @pmmmwh :)

Unfortunately tests are failing..

I'll check and update accordingly - I think it is mostly because of window.__VERDACCIO_BASENAME_UI_OPTIONS not containing the correct information.

Edit: I fixed most of the stuff. Should I remove the tests related to gegetRegistryURL too? (since we now do not have logic on manipulating the trailing slash) Or - should I update the test so that it can test when the base url is different it will get the correct one?

[codecov]

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #300   +/-   ##
======================================
  Coverage    88.2%   88.2%           
======================================
  Files         143     143           
  Lines         975     975           
  Branches      194     193    -1     
======================================
  Hits          860     860           
  Misses         97      97           
  Partials       18      18

Impacted Files	Coverage Δ
src/utils/url.ts	20% <100%> (ø)	⬆️

[ant1m4tt3r]

Looks good to me

[priscilawebdev]

Now it looks good! Thank you @pmmmwh 👏🙃

[juanpicado]

Sorry guys, but, the info dialog is broken. https://github.com/verdaccio/ui/issues/310

I'd suggest a new PR with :

• E2E that verify this works
• Please think in all use cases and scenarios
• Verify this works with url_prefix prop https://verdaccio.org/docs/en/configuration#url-prefix

export function getRegistryURL(): string {
  return window.__VERDACCIO_BASENAME_UI_OPTIONS.base;
}

We don't use server rendering, thus, the base only include that, the base domain, but does not include the path or possible queries. As consequence the window.__VERDACCIO_BASENAME_UI_OPTIONS.base will return always / as you can see in the screenshot above.

[priscilawebdev]

Hi @juanpicado that is true..I have just checked and it's broken :( I reversed the changes . Thank you.

[juanpicado]

It's fine, I think the problem is bigger that is seems so, it might need some changes in the backend. I introduced this bug with this verdaccio/verdaccio#1457

[pmmmwh]

Sorry guys, but, the info dialog is broken. #310

I'd suggest a new PR with :

• E2E that verify this works
• Please think in all use cases and scenarios
• Verify this works with url_prefix prop https://verdaccio.org/docs/en/configuration#url-prefix

export function getRegistryURL(): string {
  return window.__VERDACCIO_BASENAME_UI_OPTIONS.base;
}

We don't use server rendering, thus, the base only include that, the base domain, but does not include the path or possible queries. As consequence the window.__VERDACCIO_BASENAME_UI_OPTIONS.base will return always / as you can see in the screenshot above.

Oops - I'm sorry about that. I'll see if there's another way to achieve the correct behaviour.