Skip to content

fix(NcRichText): do not escape chars when resolving reference#8351

Merged
Antreesy merged 3 commits intomainfrom
fix/noid/rich-text-references
Mar 25, 2026
Merged

fix(NcRichText): do not escape chars when resolving reference#8351
Antreesy merged 3 commits intomainfrom
fix/noid/rich-text-references

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix NcRichText not rendering some links #8348
  • 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content
  • add docs mock for rendering references in-library for easier debugging

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

- returns link as-is

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…tring'

- 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…util-to-string'

- 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.6.0 milestone Mar 24, 2026
@Antreesy Antreesy self-assigned this Mar 24, 2026
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.49%. Comparing base (6eec54e) to head (9815a03).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8351      +/-   ##
==========================================
+ Coverage   52.37%   53.49%   +1.11%     
==========================================
  Files         104      104              
  Lines        3393     3395       +2     
  Branches      989      988       -1     
==========================================
+ Hits         1777     1816      +39     
+ Misses       1360     1333      -27     
+ Partials      256      246      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✔️ Thanks a lot 💚

Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No security concern ✅
Tested ✅

@Antreesy Antreesy merged commit a60b485 into main Mar 25, 2026
27 checks passed
@Antreesy Antreesy deleted the fix/noid/rich-text-references branch March 25, 2026 16:24
@Antreesy
Copy link
Copy Markdown
Contributor Author

/backport to stable8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcRichText not rendering some links

3 participants