Skip to content

[stable8] fix(NcRichText): do not escape chars when resolving reference#8356

Merged
Antreesy merged 3 commits intostable8from
backport/8351/stable8
Apr 15, 2026
Merged

[stable8] fix(NcRichText): do not escape chars when resolving reference#8356
Antreesy merged 3 commits intostable8from
backport/8351/stable8

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Mar 25, 2026

Backport of #8351

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

- returns link as-is

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@backportbot backportbot Bot added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 25, 2026
@backportbot backportbot Bot added this to the 8.37.0 milestone Mar 25, 2026
…tring'

- 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8351/stable8 branch from e7d7089 to 24a12af Compare March 25, 2026 17:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.38%. Comparing base (f57b50c) to head (f43f092).
⚠️ Report is 24 commits behind head on stable8.

Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8356      +/-   ##
===========================================
+ Coverage    45.85%   46.38%   +0.53%     
===========================================
  Files          194      194              
  Lines         4892     4892              
  Branches      1262     1262              
===========================================
+ Hits          2243     2269      +26     
+ Misses        2561     2535      -26     
  Partials        88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remade package.json and adjusted test for Vue 2 + Jest

…util-to-string'

- 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8351/stable8 branch from 24a12af to f43f092 Compare March 25, 2026 17:22
@Antreesy Antreesy marked this pull request as ready for review March 25, 2026 18:05
@Antreesy Antreesy modified the milestones: 8.37.0, 8.38.0 Apr 15, 2026
Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code re-reviewed, but please be aware that i have not tested

@Antreesy Antreesy merged commit 7903edc into stable8 Apr 15, 2026
21 checks passed
@Antreesy Antreesy deleted the backport/8351/stable8 branch April 15, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants