feat: Semantic font weights for interactive elements#8469
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8469 +/- ##
==========================================
+ Coverage 54.47% 54.55% +0.07%
==========================================
Files 105 106 +1
Lines 3411 3439 +28
Branches 996 1003 +7
==========================================
+ Hits 1858 1876 +18
- Misses 1313 1322 +9
- Partials 240 241 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c91b01d to
6cf9f39
Compare
ShGKme
left a comment
There was a problem hiding this comment.
In addition to the library, we have some global styles for interactive elements, for example:
https://github.com/nextcloud/server/blob/stable33/core/css/inputs.scss
And (barely used) global utils like this:
https://github.com/nextcloud/server/blob/stable33/core/css/global.scss#L75-L77
2efc512 to
7ee7ca5
Compare
Counterpart of nextcloud-libraries/nextcloud-vue#8469 Signed-off-by: kramo <git@kramo.page>
Counterpart of nextcloud-libraries/nextcloud-vue#8469 Signed-off-by: kramo <git@kramo.page>
e81b926 to
a257744
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice improvement, 👍 design-wise! :)
ShGKme
left a comment
There was a problem hiding this comment.
Some fallback values are missing.
Because the variable is not available in older versions, it is better to always have a fallback, even if it is the same value.
|
/backport to stable8 |
Counterpart of nextcloud-libraries/nextcloud-vue#8469 Signed-off-by: kramo <git@kramo.page>
Counterpart of nextcloud-libraries/nextcloud-vue#8469 Signed-off-by: kramo <git@kramo.page>
a0eadf3 to
7d2d033
Compare
7d2d033 to
26567e9
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/8469/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26567e9b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8469/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
All general text should now be weight 400, interactive controls 500, and headings 600. Also added variables, as suggested by @ShGKme.
Depends on nextcloud/server#59899
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable