feat(NcAppSettingsDialog): new navigation design#8477
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8477 +/- ##
==========================================
+ Coverage 54.57% 54.60% +0.02%
==========================================
Files 106 106
Lines 3441 3443 +2
Branches 1003 1005 +2
==========================================
+ Hits 1878 1880 +2
Misses 1322 1322
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Dialog navigation is not only the It might make sense to update the design from the |
susnux
left a comment
There was a problem hiding this comment.
Same question here: What about backwards compatibility?
Keep in mind this is also used in old server versions.
So we use legacy fallbacks to keep the existing design for old server versions, for example see here: #7351
basically: add new styles by default and add some legacy class if server version is < 34.
Then apply the old styles for the legacy class.
Maybe it makes sense to strip the navigation completely, so make the navigation a part of the app settings dialog. Meaning its specific to that component, so we maybe want to just use this design here. So in the future we can deprecate the navigation of the NcDialog or at least make it more generic. |
6d21a5c to
fdb9d8a
Compare
kra-mo
left a comment
There was a problem hiding this comment.
Currently, the "General" text is stuck to the top of the dialog too much.
To translate this to a more actionable complaint, the top of the content needs more padding :)
| $navigation-width: 200px; | ||
| // Opaque tint for the dialog surface so the modal stays a solid panel | ||
| // (translucent over `transparent` would let background content bleed through). | ||
| $nav-tint-solid: color-mix(in srgb, var(--color-primary-element) 8%, var(--color-main-background)); |
There was a problem hiding this comment.
I'd make this the same color as form boxes, so for now this:
| // Opaque tint for the dialog surface so the modal stays a solid panel | ||
| // (translucent over `transparent` would let background content bleed through). | ||
| $nav-tint-solid: color-mix(in srgb, var(--color-primary-element) 8%, var(--color-main-background)); | ||
| $nav-tint-strong: color-mix(in srgb, var(--color-primary-element) 16%, transparent); |
There was a problem hiding this comment.
This can also be less strong in this case.
|
It would be good to reduce the maximum width for this dialog now by a bit as well. |
|
The font-weight also should not change based on selection. It should always be |
@jancborchardt those titles are not fixed i.e position is determined by scroll but let me see what can be done. |
|
@nfebe right, they shouldn't be fixed. But what I mean is that in the screenshot you showed, the first header is too far up. Did you scroll slightly down there? If not, would be good to give it a bit of whitespace above. |
fdb9d8a to
0e49f82
Compare
There was a problem hiding this comment.
Same comment about the height of the pill for the selected item as for the general left navigation. It should be a little less tall. Other than that, looks good to me.
One thing I would still change, if possible, is to reduce the maximum width of the entire dialog by a bit. I raised this in the past, but we agreed that we'd do it once we redesign the rest, so I think now is the time.
0e49f82 to
1e0a51f
Compare
|
Fixed responsiveness. |
1e0a51f to
9b8b844
Compare
ca1c42a to
ddd31f0
Compare
|
The colors are still different. Hover effect should make the color darker in the light theme, but lighter in the dark one. Recording.2026-05-06.000325.mp4 |
The settings dialog title now sits over a tinted navigation column on the inline-start edge of the dialog, replacing the centered header. Navigation links use the default button weight with a rounded inline-start stripe on the active item, mirroring the navigation-item redesign. Closes #7641 Signed-off-by: nfebe <fenn25.fn@gmail.com>
ddd31f0 to
fa8a678
Compare
ShGKme
left a comment
There was a problem hiding this comment.
The color is still different and the title on mobile is not aligned.
But this is not critical. Let's merge as it is and adjust in the follow-up, so apps can start testing the new design.
|
Renamed a bit for the changelog to clarify it for library users. There was a significant design change, not only the "alignment" |








The settings dialog title now sits over a tinted navigation column.
🖼️ Screenshots
Closes #7641