Skip to content

feat(NcAppSettingsDialog): new navigation design#8477

Merged
nfebe merged 1 commit intomainfrom
feat/align-settings-title-with-sidebar
May 6, 2026
Merged

feat(NcAppSettingsDialog): new navigation design#8477
nfebe merged 1 commit intomainfrom
feat/align-settings-title-with-sidebar

Conversation

@nfebe
Copy link
Copy Markdown
Contributor

@nfebe nfebe commented Apr 27, 2026

The settings dialog title now sits over a tinted navigation column.

🖼️ Screenshots

🏚️ Before 🏡 After
settings-dialog-before-7641 image

Closes #7641

@nfebe nfebe requested review from ShGKme, kra-mo and susnux April 27, 2026 13:12
@nfebe nfebe added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.60%. Comparing base (f4ccd08) to head (fa8a678).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8477      +/-   ##
==========================================
+ Coverage   54.57%   54.60%   +0.02%     
==========================================
  Files         106      106              
  Lines        3441     3443       +2     
  Branches     1003     1005       +2     
==========================================
+ Hits         1878     1880       +2     
  Misses       1322     1322              
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme changed the title feat(settings-dialog): Align title with navigation column feat(NcAppSettingsDialog): Align title with navigation column Apr 27, 2026
@ShGKme ShGKme added the enhancement New feature or request label Apr 27, 2026
@ShGKme ShGKme added this to the 9.7.0 milestone Apr 27, 2026
@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented Apr 27, 2026

image

On the design draft:

  • The main content section is rounded with a border, like with the new design on NcAppContent
  • The dialog title is left aligned with the buttons' text
  • The dialog title and the first section title are aligned
  • Left/right offset around the buttons are equal

Not sure about the font-size, though...

@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented Apr 27, 2026

Dialog navigation is not only the NcAppSettingsDialog feature, but also the NcDialog feature. For example, used in the file picker dialog.

It might make sense to update the design from the NcDialog side. But I'm unsure how we can do it preventing breaking changes.

Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here: What about backwards compatibility?
Keep in mind this is also used in old server versions.

So we use legacy fallbacks to keep the existing design for old server versions, for example see here: #7351

basically: add new styles by default and add some legacy class if server version is < 34.
Then apply the old styles for the legacy class.

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 27, 2026

It might make sense to update the design from the NcDialog side. But I'm unsure how we can do it preventing breaking changes.

Maybe it makes sense to strip the navigation completely, so make the navigation a part of the app settings dialog.
Then you can style it like you want, the design of the current dialog navigation was mostly inspired by the filepicker.

Meaning its specific to that component, so we maybe want to just use this design here. So in the future we can deprecate the navigation of the NcDialog or at least make it more generic.

@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented Apr 27, 2026

settings-dialog-after-7641

@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch 2 times, most recently from 6d21a5c to fdb9d8a Compare April 27, 2026 18:17
Copy link
Copy Markdown
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfebe regarding the last screenshot: The heading in the content container should be aligned with the heading on the left, as in the mockup by @kra-mo in #7641

Currently, the "General" text is stuck to the top of the dialog too much.

Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the "General" text is stuck to the top of the dialog too much.

To translate this to a more actionable complaint, the top of the content needs more padding :)

$navigation-width: 200px;
// Opaque tint for the dialog surface so the modal stays a solid panel
// (translucent over `transparent` would let background content bleed through).
$nav-tint-solid: color-mix(in srgb, var(--color-primary-element) 8%, var(--color-main-background));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make this the same color as form boxes, so for now this:

--color-primary-element-extra-light: hsl(from var(--color-primary-element-light) h s calc(l * 1.045));

// Opaque tint for the dialog surface so the modal stays a solid panel
// (translucent over `transparent` would let background content bleed through).
$nav-tint-solid: color-mix(in srgb, var(--color-primary-element) 8%, var(--color-main-background));
$nav-tint-strong: color-mix(in srgb, var(--color-primary-element) 16%, transparent);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be less strong in this case.

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Apr 28, 2026

It would be good to reduce the maximum width for this dialog now by a bit as well.

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Apr 28, 2026

The font-weight also should not change based on selection. It should always be 500. See #8469

@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented Apr 28, 2026

@nfebe regarding the last screenshot: The heading in the content container should be aligned with the heading on the left, as in the mockup by @kra-mo in #7641

@jancborchardt those titles are not fixed i.e position is determined by scroll but let me see what can be done.

@jancborchardt
Copy link
Copy Markdown
Contributor

@nfebe right, they shouldn't be fixed. But what I mean is that in the screenshot you showed, the first header is too far up.

Did you scroll slightly down there? If not, would be good to give it a bit of whitespace above.

@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented Apr 28, 2026

@jancborchardt @kra-mo

image

@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch from fdb9d8a to 0e49f82 Compare April 28, 2026 16:18
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about the height of the pill for the selected item as for the general left navigation. It should be a little less tall. Other than that, looks good to me.

One thing I would still change, if possible, is to reduce the maximum width of the entire dialog by a bit. I raised this in the past, but we agreed that we'd do it once we redesign the rest, so I think now is the time.

Copy link
Copy Markdown
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile view is broken.

image

Comment thread src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue Outdated
@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch from 0e49f82 to 1e0a51f Compare April 29, 2026 13:40
@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented Apr 29, 2026

Fixed responsiveness.

@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented Apr 29, 2026

The title and the close button are not visible

image

@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch from 1e0a51f to 9b8b844 Compare April 29, 2026 18:14
@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented Apr 29, 2026

See a stale version was pushed? updated.

image

@Antreesy Antreesy modified the milestones: 9.7.0, 9.7.1 Apr 30, 2026
@nickvergessen
Copy link
Copy Markdown
Contributor

This is broken on dark mode btw: Instead of getting brighter on hover (?) like the "Blur camera …" setting, it tries to get darker and that's not visible anymore.

grafik

@susnux susnux modified the milestones: 9.7.1, 9.8.0 May 4, 2026
@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch 4 times, most recently from ca1c42a to ddd31f0 Compare May 4, 2026 16:10
@nfebe nfebe requested review from ShGKme and jancborchardt May 5, 2026 15:31
@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented May 5, 2026

The colors are still different. Hover effect should make the color darker in the light theme, but lighter in the dark one.

Recording.2026-05-06.000325.mp4

@nfebe
Copy link
Copy Markdown
Contributor Author

nfebe commented May 6, 2026

image

The settings dialog title now sits over a tinted navigation column on
the inline-start edge of the dialog, replacing the centered header.
Navigation links use the default button weight with a rounded
inline-start stripe on the active item, mirroring the navigation-item
redesign.

Closes #7641

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/align-settings-title-with-sidebar branch from ddd31f0 to fa8a678 Compare May 6, 2026 09:36
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color is still different and the title on mobile is not aligned.

But this is not critical. Let's merge as it is and adjust in the follow-up, so apps can start testing the new design.

@nfebe nfebe merged commit 6371244 into main May 6, 2026
27 checks passed
@nfebe nfebe deleted the feat/align-settings-title-with-sidebar branch May 6, 2026 13:28
@ShGKme ShGKme changed the title feat(NcAppSettingsDialog): Align title with navigation column feat(NcAppSettingsDialog): new navigation design May 6, 2026
@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented May 6, 2026

Renamed a bit for the changelog to clarify it for library users. There was a significant design change, not only the "alignment"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Left-align title of settings

7 participants