click outside to close sidebar

[jakobroehrl]

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

• Resolves: Click outside card should close sidebar #1794
• Target version: master

With this change the sidebar no longer opens at all.
@juliushaertl do you have an idea how to solve it?

[juliusknorr]

Doesn't work that easy, as this basically blocks the sidebar from being opened in the first run when clicking on a card.

[jakobroehrl]

@juliushaertl How to do this?
Would it be easier to implement closing with the esc key?

[juliusknorr]

Well escape key should probably also work but the click would be still useful. To make this work you would basically need to make sure that the click was triggered on the board dom element and not on a card in the v-click-outside handler.

[jakobroehrl]

It doesn't work with that either: Sidebar no longer opens

deck/src/App.vue

Line 26 in 5e3661c

<div id="app-content" @click="clickCloseSidebar()">

[marcelklehr]

To make this work you would basically need to make sure that the click was triggered on the board dom element and not on a card in the v-click-outside handler.

Fixed by using @juliushaertl's approach :)

[juliusknorr]

Seems to have caused a regression when trying to open the board sidebar as that click opens the sidebar but closes it directly again. Maybe we should only trigger it when clicking the board content area somehow.