fix(Sidebar): Only close sidebar on v-click-outside for specific targets#4350
Merged
juliusknorr merged 3 commits intomasterfrom Jan 2, 2023
Merged
fix(Sidebar): Only close sidebar on v-click-outside for specific targets#4350juliusknorr merged 3 commits intomasterfrom
juliusknorr merged 3 commits intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
Pushed a bit of cypress coverage for the sharing sidebar and a follow up fix that allows to clean up cypress a bit :) |
marcelklehr
approved these changes
Jan 2, 2023
Member
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
Sorry for this oversight. Tested and works. Although clicking on the navigation panel doesn't close the sidebar anymore.
Member
Author
|
Thanks for the fast review. I actually did that intentional as it would preserve the board sidebar in open state when switching boards, which seemed more useful than always closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #2272 (comment)