Skip to content

Updating nf-core modules and subworkflows, including preparation for topics#487

Merged
JoseEspinosa merged 69 commits intonf-core:devfrom
Kevin-Brockers:dev_topic_channel_adaptation
Mar 19, 2026
Merged

Updating nf-core modules and subworkflows, including preparation for topics#487
JoseEspinosa merged 69 commits intonf-core:devfrom
Kevin-Brockers:dev_topic_channel_adaptation

Conversation

@Kevin-Brockers
Copy link
Copy Markdown

@Kevin-Brockers Kevin-Brockers commented Mar 12, 2026

PR checklist

  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,singularity --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).

Brief description

  1. Adapted to topics in named workflow: ad9fa86

  2. Updated nf-core modules, see: 2edc288

  3. subworkflows and modules, see: b4b9757

  4. Removed ch_version from subworkflows (local)

  5. Changed CUSTOM_GETCHROMSIZES to SAMTOOLS_FAIDX, see: 4ddf007

  6. a bit back and forth to fix things and run tests on a slurm cluster. I think will be fine if we squash the commits.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a1b2210

+| ✅ 266 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-03-18 20:29:48

Copy link
Copy Markdown
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! Only some suggestions

Comment thread CHANGELOG.md Outdated
Comment thread main.nf Outdated
Comment thread .nf-core.yml Outdated
@nf-core nf-core deleted a comment from JoseEspinosa Mar 13, 2026
@nf-core nf-core deleted a comment from JoseEspinosa Mar 13, 2026
Copy link
Copy Markdown
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to amd64 images for fixing test

Comment thread modules/local/frip_score/main.nf Outdated
Comment thread modules/local/star_align/main.nf Outdated
Copy link
Copy Markdown
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more updated images

Comment thread modules/local/star_genomegenerate/main.nf Outdated
Comment thread modules/local/plot_macs3_qc/main.nf Outdated
Copy link
Copy Markdown
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR now and work on a follow-up PR to address some issues I found here, as this PR is already very large.

@JoseEspinosa JoseEspinosa merged commit 983d0ff into nf-core:dev Mar 19, 2026
20 checks passed
@JoseEspinosa JoseEspinosa mentioned this pull request Mar 23, 2026
5 tasks
@Kevin-Brockers Kevin-Brockers deleted the dev_topic_channel_adaptation branch March 31, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants