Skip to content

MultiQC config rebuild and documentation changes#108

Closed
jfy133 wants to merge 4 commits intonf-core:devfrom
jfy133:dev
Closed

MultiQC config rebuild and documentation changes#108
jfy133 wants to merge 4 commits intonf-core:devfrom
jfy133:dev

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Dec 15, 2018

This includes:

  • multiqc rebuild, starting with fixing separating out FastQC output
  • adding some important singularity information to installation documentation
  • fixes readme typo

NOTE: New MultiQC config will not work until the FastQC outputs are changed accordingly (see the commit)

Many thanks to contributing to nf-core/eager!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

Beginning rebuild of custom MultiQC configuration file.

This commit starts with separating out pre- and post-adapter removal config files.

This will require modification to nextflow channel outputs for the corresponding FastQC 
steps to include in the output html and/or zip files the suffixs: '_preAR_fastqc.html' and
'_postAR_fastqc.html' for pre- and post-adapterremoval steps accordingly.
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Dec 15, 2018

Actually - the 'html' bit doesn't work - is seems zip is indeed required. Will send new PR

@jfy133 jfy133 closed this Dec 15, 2018
apeltzer added a commit that referenced this pull request Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant