Rename reference to fasta in all cases#131
Merged
apeltzer merged 3 commits intonf-core:devfrom Jan 28, 2019
Merged
Conversation
jfy133
requested changes
Jan 28, 2019
Member
There was a problem hiding this comment.
This fixes the indexing issue - but downstream there a couple of places where the pipeline crashes, such as damageprofiler.
Maybe do a scan of anywhere else a fasta channel is used (e.g. possibly DamageProfiler and PMDtools - as based on line 242, for example.
Error where I discovered the issue:
ERROR ~ Error executing process > 'damageprofiler (ABM006.A0101_S0_L002_R1_001.sorted)'
Caused by:
Missing output file(s) `*/*.json` expected by process `damageprofiler (ABM006.A0101_S0_L002_R1_001.sorted)`
Command executed:
damageprofiler -i ABM006.A0101_S0_L002_R1_001.sorted.bam -r Tannerella_forsythia_9212.fa -l 100 -t 15 -o .
Command exit status:
0
Command output:
DamageProfiler v0.3.9
Work dir:
/projects1/users/fellows/nextflow/eager2/dev_testing/eager2/01-actual_reference/tannerella_forsythia/Multiple/work/83/a9d4770fda4a5d6c473f92618be07d
Member
Author
|
Its an outdated environment in this case - can you download a new singularity container? |
Member
Author
|
(new version should be DamageProfiler 0.4+, that can write out JSON log files, required for multiQC). |
jfy133
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the error in #130 and your issues @jfy133 :-)
Automatically renames any
--fastareference genome to use the*.fastafile extension if its not present already 👍