Skip to content

Fix for post-dup steps#151

Merged
apeltzer merged 7 commits intonf-core:devfrom
apeltzer:fix-post-dedup-steps
Feb 27, 2019
Merged

Fix for post-dup steps#151
apeltzer merged 7 commits intonf-core:devfrom
apeltzer:fix-post-dedup-steps

Conversation

@apeltzer
Copy link
Copy Markdown
Member

Many thanks to contributing to nf-core/eager!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@apeltzer apeltzer requested a review from jfy133 February 25, 2019 16:22
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 25, 2019

Testing now!

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 25, 2019

Almost there I think:

Feb-25 20:45:00.068 [Actor Thread 46] ERROR nextflow.processor.TaskProcessor - Error executing process > 'multiqc'

Caused by:
  Process `multiqc` input file name collision -- There are multiple input files for each of the following file names: software_versions/software_versions_mqc.yaml, damageprofiler/dmgprof.json


Tip: view the complete command output by changing to the process work dir and entering the command `cat .command.out`
Feb-25 20:45:00.072 [Actor Thread 46] DEBUG nextflow.Session - Session aborted -- Cause: Process `multiqc` input file name collision -- There are multiple input files for each of the following file names: softwa
re_versions/software_versions_mqc.yaml, damageprofiler/dmgprof.json

@apeltzer
Copy link
Copy Markdown
Member Author

@jfy133 this should be fine now for review - @hesterjvs, this should resolve your remaining issue 👍

@apeltzer apeltzer merged commit e85b58f into nf-core:dev Feb 27, 2019
@apeltzer apeltzer deleted the fix-post-dedup-steps branch February 27, 2019 11:24
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 27, 2019

I see it's closed - but works like a charm on my dataset. Great speedy work @apeltzer, thanks !

@apeltzer
Copy link
Copy Markdown
Member Author

Yeah tested it with some more data and figured this works pretty fine now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants