Skip to content

Added post-mapping filter statistics generation#220

Merged
apeltzer merged 12 commits intonf-core:devfrom
jfy133:postmapfilter-stats
Jun 9, 2019
Merged

Added post-mapping filter statistics generation#220
apeltzer merged 12 commits intonf-core:devfrom
jfy133:postmapfilter-stats

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Jun 8, 2019

This PR duplicates the samtools flagstat step for after mapping quality filtering. This allows a user to see the effect of mapping quality filtering.

It also includes some clean-up of code comments

Note: I've manually tested this myself. The only thing that is slightly off is that the General Stats table doesn't report the name of which samtools flagstat step it is from (but it displayes pre- and post- map quality filtering in the correct order). However the menu on the left does have the correct names.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

@jfy133 jfy133 changed the title Added post-mapping filter statistic generation Added post-mapping filter statistics generation Jun 8, 2019
@jfy133 jfy133 requested review from apeltzer and maxibor June 8, 2019 18:31
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great - thanks @jfy133

@apeltzer apeltzer merged commit 69c2373 into nf-core:dev Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants